After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764141 - grl_paging_translate() doesn't handle multiple pages
grl_paging_translate() doesn't handle multiple pages
Status: RESOLVED OBSOLETE
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-24 13:08 UTC by Bastien Nocera
Modified: 2018-09-24 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2016-03-24 13:08:06 UTC
In grilo-lua-sources, the grl-guardian-eyewitness source cannot change the page_size or page_skip, only the page number to get.

grl_paging_translate() doesn't handle this.

We should review the various lua sources, and try to simplify this so that we can reduce the amount of maths one needs to do to grab the data we need.
Comment 1 Victor Toso 2016-05-07 09:57:49 UTC
Implementing a grl.paging_translate on lua-library would be enough?

page_size, page_number, offset = grl.paging_translate ()

<snip>
/* based on */
grl_paging_translate (guint skip,
                      guint count,
                      guint max_page_size,
                      guint *page_size,
                      guint *page_number,
                      guint *internal_offset);
</snip>
Comment 2 Bastien Nocera 2017-06-13 10:25:12 UTC
(In reply to Victor Toso from comment #1)
> Implementing a grl.paging_translate on lua-library would be enough?

> grl_paging_translate() doesn't handle this.

No. This helper doesn't handle the page_size or the page_skip not being changeable.
Comment 3 GNOME Infrastructure Team 2018-09-24 09:42:23 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/84.