After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764124 - glmemory: avoid creating a framebuffer every download/copy
glmemory: avoid creating a framebuffer every download/copy
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.7.91
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-24 08:52 UTC by comicfans44
Modified: 2018-11-03 11:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glmemory: avoid creating a framebuffer every download/copy (3.07 KB, patch)
2016-03-24 08:52 UTC, comicfans44 		needs-work Details | Review

Description comicfans44 2016-03-24 08:52:41 UTC 
Created attachment 324655 [details] [review]
glmemory: avoid creating a framebuffer every download/copy

this is a FIXME in glmemory, avoid creating a framebuffer every download/copy
Comment 1 Matthew Waters (ystreet00) 2016-03-25 03:32:21 UTC 
Review of attachment 324655 [details] [review]:

There is more than one usage of framebuffers in gstglmemory that this doesn't consider.  There's also one in gstglmemorypbo that should also be cached.
Comment 2 comicfans44 2016-03-25 05:57:02 UTC 
(In reply to Matthew Waters (ystreet00) from comment #1)
> Review of attachment 324655 [details] [review] [review]:
> 
> There is more than one usage of framebuffers in gstglmemory that this
> doesn't consider.  There's also one in gstglmemorypbo that should also be
> cached.

Oh , I didn't realize that. I reached this code by view OpenGL call trace, but my code only trigger one path of them.  should I put fbo as member of GstGLBaseMemory ,or duplicate it in GstGLMemory and GstGLMemoryPBO ?
Comment 3 Matthew Waters (ystreet00) 2016-05-15 08:58:20 UTC 
It should go in GstGLMemory, GstGLMemoryPBO is a subclass of GstGLMemory.
Comment 4 GStreamer system administrator 2018-11-03 11:46:04 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/263.