After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764075 - Do not enable code coverage unconditionally
Do not enable code coverage unconditionally
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-23 14:05 UTC by Emmanuele Bassi (:ebassi)
Modified: 2016-03-23 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Do not enable code coverage based on lcov (1.18 KB, patch)
2016-03-23 14:05 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2016-03-23 14:05:36 UTC 
See patch.
Comment 1 Emmanuele Bassi (:ebassi) 2016-03-23 14:05:58 UTC 
Created attachment 324591 [details] [review]
build: Do not enable code coverage based on lcov

Code coverage turns on various slow paths and disables optimizations. It
should be, and it usually is, an opt in configuration flag.

Enabling it should not be conditional on the existence of the lcov
binary on the system, otherwise anybody building PyGObject from Git on
any moderately complete development environment will automatically
enable code coverage even when not wanted.
Comment 2 Emmanuele Bassi (:ebassi) 2016-03-23 14:07:28 UTC 
This commit partially reverts commit 0456d9c8 — I could not do a full revert because the autogen.sh file has been modified since 2012.
Comment 3 Christoph Reiter (lazka) 2016-03-23 14:38:04 UTC 
I was wondering why I never hit this case and turns out passing arguments when sourcing only works in bash. As debian uses dash for sh EXTRA_ARGS never gets passed anyway (not sure about fedora..).
Comment 4 Christoph Reiter (lazka) 2016-03-23 14:39:20 UTC 
Review of attachment 324591 [details] [review]:

lgtm
Comment 5 Emmanuele Bassi (:ebassi) 2016-03-23 15:21:44 UTC 
Attachment 324591 [details] pushed as 6ff29c9 - build: Do not enable code coverage based on lcov