After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764050 - per UPnP SwitchPower spec, SetTarget argument name is 'newTargetValue'
per UPnP SwitchPower spec, SetTarget argument name is 'newTargetValue'
Status: RESOLVED FIXED
Product: gupnp-tools
Classification: Other
Component: General
unspecified
Other Linux
: Normal minor
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-22 22:15 UTC by larry.j.sachs
Modified: 2019-02-22 05:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
network-light: Use newTargetValue (1.90 KB, patch)
2016-04-20 21:00 UTC, Jens Georg
committed Details | Review
examples: Use newTargetValue (2.09 KB, patch)
2016-04-20 21:02 UTC, Jens Georg
none Details | Review

Description larry.j.sachs 2016-03-22 22:15:10 UTC
per UPnP SwitchPower spec, SetTarget argument name is 'newTargetValue'

The code in src/network-light/upnp.c and the xml in data/xml/SwitchPower-scpd.xml have the SetTarget argument as 'NewTargetValue'
Comment 1 Jussi Kukkonen 2016-03-23 07:37:03 UTC
This was a spec bug, btw: the original spec had "NewTargetValue" but then they just changed it (after something like 10 years!)
Comment 2 Jens Georg 2016-04-03 17:09:26 UTC
Did that only change for NewTargetValue or are the others (RetTargetValue) changed as well=
Comment 3 Jussi Kukkonen 2016-04-04 08:17:47 UTC
(In reply to Jens Georg from comment #2)
> Did that only change for NewTargetValue or are the others (RetTargetValue)
> changed as well=

Come on, there are like three whole argument names in the spec. You can't expect them to fix all of them at once.


So the other arguments still have a capital starting letter. Committee work at its most useful.
Comment 4 Jens Georg 2016-04-20 20:57:11 UTC
m(
Comment 5 Jens Georg 2016-04-20 21:00:58 UTC
Created attachment 326456 [details] [review]
network-light: Use newTargetValue

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 6 Jens Georg 2016-04-20 21:02:20 UTC
Created attachment 326457 [details] [review]
examples: Use newTargetValue

Adapt to 2011 spec update

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 7 Jens Georg 2016-04-24 22:11:01 UTC
Comment on attachment 326456 [details] [review]
network-light: Use newTargetValue

Attachment 326456 [details] pushed as 6699fa1 - network-light: Use newTargetValue
Comment 8 Jens Georg 2016-04-25 21:43:24 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.