GNOME Bugzilla – Bug 764032
.TOML syntax file
Last modified: 2018-03-10 11:00:05 UTC
Created attachment 324543 [details] TOML syntax highlighting file Syntax file for the TOML configuration language (used by rust's cargo and others). It's inspired by INI by more well-defined and allows for arbitrary-depth lists. File copied from here: https://github.com/fcharlie/toml.lang Has copyrights and an elaborate example file that is displayed correctly. Please merge this!
Created attachment 369274 [details] [review] toml.lang: Add new definition for toml files Changes to be committed: modified: data/language-specs/Makefile.am new file: data/language-specs/toml.lang modified: po/POTFILES.skip new file: tests/syntax-highlighting/file.toml
Permission was given by the author here: https://github.com/liv-dumea/toml.lang/issues/1
Created attachment 369275 [details] [review] toml.lang: Add new definition for toml files Changes to be committed: modified: data/language-specs/Makefile.am new file: data/language-specs/toml.lang modified: po/POTFILES.skip new file: tests/syntax-highlighting/file.toml
Review of attachment 369275 [details] [review]: Thanks, some minor problems. ::: data/language-specs/toml.lang @@ +21,3 @@ +--> + +<language id="toml" _name="TOML" version="2.0" _section="Others"> _name -> name. @@ +37,3 @@ + <style id="boolean-value" _name="Boolean value" map-to="def:boolean"/> + <style id="datetime-value" _name="Datetime value" map-to="def:constant"/> + <style id="error" _name="Error" map-to="def:error"/> The same for styles.
Created attachment 369363 [details] [review] toml.lang: Add new definition for toml files Changes to be committed: modified: data/language-specs/Makefile.am new file: data/language-specs/toml.lang modified: po/POTFILES.skip new file: tests/syntax-highlighting/file.toml
Review of attachment 369363 [details] [review]: . ::: data/language-specs/toml.lang @@ +21,3 @@ +--> + +<language id="toml" name="TOML" version="2.0" _section="Others"> The _section must be "Other", not "Others" (the sections have been renamed several years ago).
Created attachment 369391 [details] [review] toml.lang: Add new definition for toml files Changes to be committed: modified: data/language-specs/Makefile.am new file: data/language-specs/toml.lang modified: po/POTFILES.skip new file: tests/syntax-highlighting/file.toml
Review of attachment 369391 [details] [review]: Looks good, thanks. But it's currently the hard code freeze, so it'll need to wait next week to merge the patch.
Thanks for the review. Looking for forward to our improved Rust support :)
Attachment 369391 [details] pushed as 4e4a9c5 - toml.lang: Add new definition for toml files
The *.lang files will be synchronized to GSV 3 soon.