After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764016 - Rygel 0.30.0 generates invalid desktop file
Rygel 0.30.0 generates invalid desktop file
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-22 07:57 UTC by Kalev Lember
Modified: 2016-03-31 10:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
data: Drop empty Categories list from desktop file (929 bytes, patch)
2016-03-22 09:32 UTC, Kalev Lember 		committed Details | Review

Description Kalev Lember 2016-03-22 07:57:49 UTC 
When building rygel 0.30.0 from tarball, the generated rygel.desktop file has an invalid line:

Categories=Exec=rygel

Looks like a newline after "Categories=" goes missing when generating .desktop from .desktop.in. Probably the easiest fix would be to drop the empty Categories= list.
Comment 1 Jens Georg 2016-03-22 08:50:27 UTC 
Meh, so much for "it's just a build system patch, should be no problem to include". Thanks.
Comment 2 Kalev Lember 2016-03-22 09:32:17 UTC 
Created attachment 324525 [details] [review]
data: Drop empty Categories list from desktop file

An empty Categories= list led to rygel.desktop losing a newline during
.desktop.in.in -> .desktop.in generation and ending up with an invalid
Categories=Exec=rygel line.

Work this around by dropping the empty list.
Comment 3 Jens Georg 2016-03-31 09:36:42 UTC 
Review of attachment 324525 [details] [review]:

+1
Comment 4 Kalev Lember 2016-03-31 10:00:56 UTC 
Attachment 324525 [details] pushed as 5286e95 - data: Drop empty Categories list from desktop file