After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764015 - Libsoup 2.54.0 fails to build with --without-gnome
Libsoup 2.54.0 fails to build with --without-gnome
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.54.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2016-03-22 05:33 UTC by Kari Hänninen
Modified: 2016-03-23 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix build with --without-gnome (1.39 KB, patch)
2016-03-22 13:02 UTC, Dan Winship
none Details | Review

Description Kari Hänninen 2016-03-22 05:33:34 UTC
+./configure --prefix=/usr --without-gnome --disable-silent-rules --disable-static --disable-nls --disable-vala
+make
make  all-recursive
make[1]: Entering directory '/mnt/pkg/pkgmk_work/libsoup/src/libsoup-2.54.0'
Making all in libsoup
make[2]: Entering directory '/mnt/pkg/pkgmk_work/libsoup/src/libsoup-2.54.0/libsoup'
Makefile:2171: *** Need to define SoupGNOME_2_4_gir_MSVC_FILES.  Stop.
make[2]: Leaving directory '/mnt/pkg/pkgmk_work/libsoup/src/libsoup-2.54.0/libsoup'
Makefile:562: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/mnt/pkg/pkgmk_work/libsoup/src/libsoup-2.54.0'
Makefile:465: recipe for target 'all' failed
make: *** [all] Error 2
Comment 1 Dan Winship 2016-03-22 13:02:26 UTC
Created attachment 324538 [details] [review]
Fix build with --without-gnome

Chun-wei / nacho, is this fix OK on Windows?
Comment 2 Fan, Chun-wei 2016-03-23 07:43:28 UTC
Hi Dan,

Sorry for the delay...

Since this is not about dist'ing the package at this point, I think this patch should be fine.  Sorry for not seeing this when doing the patches for Visual Studio support.

With blessings, thank you!
Comment 3 Ignacio Casal Quinteiro (nacho) 2016-03-23 07:46:45 UTC
Review of attachment 324538 [details] [review]:

Yeah it should be fine
Comment 4 Dan Winship 2016-03-23 12:25:19 UTC
Fixed in git, and put out a new 2.54.0.1 tarball. Thanks everyone.