After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763971 - No way to go back to notes after Trash view
No way to go back to notes after Trash view
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: UI
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-21 03:59 UTC by Mohammed Sadiq
Modified: 2017-06-15 18:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main-toolbar: Stuck in Trash View (2.05 KB, patch)
2017-06-15 18:54 UTC, Isaque Galdino 		committed Details | Review

Description Mohammed Sadiq 2016-03-21 03:59:28 UTC 
On certain conditions, there seems no way to go back to the notes available from Trash view, other than reopning Notes.

How to reproduce:
1. Create some notes
2. Move any one (or more) notes to trash
3. Open trash via Application menu -> View trash
4. Now Click 'Empty trash' or select all notes in trash and delete

Now the back button is replaced with New button, but the notes that are not deleted are not listed. Once the application is re-opened other notes are shown.
Comment 1 Isaque Galdino 2017-06-15 18:54:57 UTC 
Created attachment 353857 [details] [review]
main-toolbar: Stuck in Trash View

When you empty trash, in trash view, the main toolbar changes and you
get stuck in that view. The only way to leave it is closing the
application.

That happens because the window state changes from ARCHIVE_VIEW to
NO_NOTE, but this stated is shared by MAIN_VIEW as well, so it gets
lost.

This commit change the behavior to whenever you click empty trash, the
window state continues to be ARCHIVE_VIEW, which is the default when you
check Trash for the first time even without items.
Comment 2 Isaque Galdino 2017-06-15 18:56:02 UTC 
Review of attachment 353857 [details] [review]:

Pushed to master