After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763915 - next/previous match moves past neighboring match
next/previous match moves past neighboring match
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-19 13:10 UTC by Fangwen Yu
Modified: 2016-03-20 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix move search (1.12 KB, patch)
2016-03-19 13:12 UTC, Fangwen Yu 		none Details | Review
fix move search (add workaround for vim) (2.17 KB, patch)
2016-03-20 06:44 UTC, Fangwen Yu 		none Details | Review
fix indentation for the previous patch (2.54 KB, patch)
2016-03-20 06:51 UTC, Fangwen Yu 		none Details | Review
fix move search (2.97 KB, patch)
2016-03-20 13:21 UTC, Fangwen Yu 		committed Details | Review
fix search movement in vim visual mode (3.65 KB, patch)
2016-03-20 15:48 UTC, Fangwen Yu 		committed Details | Review

Description Fangwen Yu 2016-03-19 13:10:42 UTC 
When moving to next/previous match, Builder will move past neighboring match.

If you have "foofoo foo" in the buffer and search for "foo", the highlight will jump from the first "foo" to the third when moving forward.
Comment 1 Fangwen Yu 2016-03-19 13:12:29 UTC 
Created attachment 324335 [details] [review]
fix move search
Comment 2 sébastien lafargue 2016-03-19 13:49:19 UTC 
Review of attachment 324335 [details] [review]:

beware that in Vim mode we use a block cursor. this mean that the real selection end one char before the visual selection so you must take this into account
Comment 3 Fangwen Yu 2016-03-20 06:44:58 UTC 
Created attachment 324355 [details] [review]
fix move search (add workaround for vim)

Add workaround for vim.

This updated patch also fixes a copy/paste typo, which causes "n" not work well with digital prefix in vim mode.
Comment 4 Fangwen Yu 2016-03-20 06:51:00 UTC 
Created attachment 324356 [details] [review]
fix indentation for the previous patch
Comment 5 sébastien lafargue 2016-03-20 09:48:28 UTC 
Review of attachment 324356 [details] [review]:

work in vim normal mode but need to be fixed on visual mode too
Comment 6 Fangwen Yu 2016-03-20 13:21:24 UTC 
Created attachment 324360 [details] [review]
fix move search

vim visual mode still needs to be fixed.
Comment 7 sébastien lafargue 2016-03-20 13:26:42 UTC 
Review of attachment 324360 [details] [review]:

LGTM, we'll fix other search problems in another patch
Comment 8 Fangwen Yu 2016-03-20 15:48:26 UTC 
Created attachment 324365 [details] [review]
fix search movement in vim visual mode
Comment 9 sébastien lafargue 2016-03-20 17:28:34 UTC 
Review of attachment 324365 [details] [review]:

LGTM