After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763911 - Clone buttons label is not translatable
Clone buttons label is not translatable
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-19 11:16 UTC by Gabor Kelemen
Modified: 2016-03-30 09:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix for the problem (976 bytes, patch)
2016-03-19 11:16 UTC, Gabor Kelemen
none Details | Review

Description Gabor Kelemen 2016-03-19 11:16:24 UTC
Created attachment 324330 [details] [review]
Fix for the problem

In Settings -> Profiles the Clone button is not translatable.
As we are in every possible freeze, fixing this has to wait until 3.20.1.
Comment 1 Christian Persch 2016-03-19 12:19:42 UTC
Fixed on master after branching.
Comment 2 Piotr Drąg 2016-03-24 01:49:24 UTC
Pushing this to gnome-3-20 would not be a string freeze break, and would be much appreciated.
Comment 3 Christian Persch 2016-03-24 09:14:47 UTC
Ok to cherry-pick -x to gnome-3-20.
Comment 4 Debarshi Ray 2016-03-24 10:04:36 UTC
(In reply to Christian Persch from comment #3)
> Ok to cherry-pick -x to gnome-3-20.

Done.
Comment 5 Egmont Koblinger 2016-03-30 06:40:13 UTC
Let me hijack and reopen this bug. There are a few more, as mentioned at https://bugzilla.redhat.com/show_bug.cgi?id=1322120.

(What's the generic take on string freeze here? Common sense tells me that if the untranslated string already appears on the UI, the situation is not made any worse by marking it for translation. Although I guess some people need to be notified about what's going on...?)
Comment 6 Gabor Kelemen 2016-03-30 09:37:27 UTC
Hi Egmont

Feel free to hijack :)

The generic take on string freeze is that marking existing strings for translation is not a freeze break, only adding new ones or modifying existing ones needs approval up front.

Translators are automatically notified about new translatable strings in frozen branches so there is no need to do that manually.
If you need approval for new strings, you should write to gnome-i18n@.

More details here: https://wiki.gnome.org/TranslationProject/HandlingStringFreezes
Comment 7 Egmont Koblinger 2016-03-30 09:56:48 UTC
False reopening, sorry.

The said strings are properly translated on Hungarian UI (both master and gnome-3-20), so it's only missing translations in some languages.