After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763906 - Worm names at the bottom of the main window are not localized
Worm names at the bottom of the main window are not localized
Status: RESOLVED FIXED
Product: gnome-nibbles
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-nibbles-maint
gnome-nibbles-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-19 09:24 UTC by Gabor Kelemen
Modified: 2016-03-20 20:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of the problem (16.47 KB, image/png)
2016-03-19 09:24 UTC, Gabor Kelemen 		  Details
Allow translating worm name in scoreboard (924 bytes, patch)
2016-03-19 15:18 UTC, Michael Catanzaro 		none Details | Review
Allow translating worm name in scoreboard (1.05 KB, patch)
2016-03-19 15:21 UTC, Michael Catanzaro 		committed Details | Review
Main window when running gnome-nibbles localized (33.72 KB, image/png)
2016-03-20 17:03 UTC, Gabor Kelemen 		  Details
screenshot of it working (15.52 KB, image/png)
2016-03-20 20:57 UTC, Michael Catanzaro 		  Details

Description Gabor Kelemen 2016-03-19 09:24:44 UTC 
Created attachment 324321 [details]
Screenshot of the problem

They should be localized.

These come from gnome-nibbles.vala, the "register" function.
Comment 1 Michael Catanzaro 2016-03-19 15:18:43 UTC 
Created attachment 324341 [details] [review]
Allow translating worm name in scoreboard
Comment 2 Michael Catanzaro 2016-03-19 15:21:42 UTC 
Created attachment 324342 [details] [review]
Allow translating worm name in scoreboard
Comment 3 Michael Catanzaro 2016-03-20 02:11:31 UTC 
Attachment 324342 [details] pushed as ba35f77 - Allow translating worm name in scoreboard
Comment 4 Gabor Kelemen 2016-03-20 17:02:16 UTC 
I have just downloaded the latest Gnome-continuous image.
I'm sorry to report this, but I don't see "Player %d" in the UI at all if I start gnome-nibbles localized (tried hu and de). However it shows up in English.
Comment 5 Gabor Kelemen 2016-03-20 17:03:08 UTC 
Created attachment 324374 [details]
Main window when running gnome-nibbles localized
Comment 6 Michael Catanzaro 2016-03-20 20:57:35 UTC 
Created attachment 324386 [details]
screenshot of it working

Works for me; I also built GTK+ master to check for regressions there. I would say: check again in tomorrow's Continuous image (it might have be some regression fixed recently), and if we're lucky it might be fixed. If it's still broken, file a different bug please.
Comment 7 Michael Catanzaro 2016-03-20 20:58:28 UTC 
Oh, I missed that you only see text in English and not in other locales. Hm, that doesn't seem like a GTK+ regression. I don't know how to explain that....