After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763905 - Worm color names are not localized in the Settings panel
Worm color names are not localized in the Settings panel
Status: RESOLVED FIXED
Product: gnome-nibbles
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-nibbles-maint
gnome-nibbles-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-19 09:21 UTC by Gabor Kelemen
Modified: 2016-03-20 02:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of the problem (30.22 KB, image/png)
2016-03-19 09:21 UTC, Gabor Kelemen 		  Details
Allow translating colors in preferences dialog (1.13 KB, patch)
2016-03-19 15:30 UTC, Michael Catanzaro 		committed Details | Review

Description Gabor Kelemen 2016-03-19 09:21:42 UTC 
Created attachment 324320 [details]
Screenshot of the problem

On the Settings window the possible worm color names are not translated.

These come from nibbles-view.vala, the color_lookup array, but the defaults for each worm are stored in org.gnome.nibbles.gschema.xml, so care must be taken to make them translatable at both places.
Comment 1 Michael Catanzaro 2016-03-19 15:24:21 UTC 
Note that gschema translation is automatically handled by intltool. Descriptions should be translatable, but not enum values (as then your settings would break when switching locales).
Comment 2 Michael Catanzaro 2016-03-19 15:30:15 UTC 
Created attachment 324343 [details] [review]
Allow translating colors in preferences dialog

Could you test this one please? I'm not sure if it works.
Comment 3 Gabor Kelemen 2016-03-19 16:03:45 UTC 
Sorry, I don't have a build environment right now, I used gnome-continuous. It looks good, though, thanks.
Comment 4 Michael Catanzaro 2016-03-20 02:11:21 UTC 
Attachment 324343 [details] pushed as dd4c879 - Allow translating colors in preferences dialog