Created attachment 324265 [details] [review]
appNotification: Dismiss undo notifications on shutdown

When the user removes an account, we only hide it initially to give
the user the chance to undo the action. Currently when we quit while
the undo notification is still shown, the account gets stuck in the
hidden state - make sure to properly dismiss the notification to
avoid this case.

Created attachment 324283 [details] [review]
appNotification: Dismiss undo notifications on shutdown

When the user removes an account, we only hide it initially to give
the user the chance to undo the action. Currently when we quit while
the undo notification is still shown, the account gets stuck in the
hidden state - make sure to properly dismiss the notification to
avoid this case.

Review of attachment 324283 [details] [review]:

Just to be clear: dismissing the notification is not the real concern here, right ? It is just a way to trigger removing the account for good ?
The commit message should make that clear

Created attachment 324287 [details] [review]
appNotification: Dismiss undo notifications on shutdown

(In reply to Matthias Clasen from comment #3)
> Just to be clear: dismissing the notification is not the real concern here,
> right ? It is just a way to trigger removing the account for good ?

Technically the notification is generic and just emits either ::closed or ::undo, depending on whether the action should go ahead or be undone. But yes, for now this is only used for account removal, and making sure to emit ::closed on destroy is a way to make sure that a "removed" account is actually removed.

Attachment 324287 [details] pushed as fec3606 - appNotification: Dismiss undo notifications on shutdown