GNOME Bugzilla – Bug 763850
Add License GTK_LICENSE_AGPL_3_0 to GtkLicense enum
Last modified: 2016-03-25 18:05:11 UTC
These days everything is getting into cloud. And in gtk, broadway backend provides such a function that the software runs somewhere else and only the service is provided via network. So, in the near future GNU Affero GPL license shall be used for several pieces of free software that are considered to be run over the network. GTK_LICENSE_AGPL_3_0 symbol shall help developers to use GNU Affero GPL easy. Though the bug 627644 requested for GNU AGPL3+ it seems not found (atleast in documentation).
A patch would be appreciated
Created attachment 324271 [details] [review] Add support for GNU AGPL v3+ Hope, I haven't miss anything
Review of attachment 324271 [details] [review]: Looks good to me; should be pushed after branching master. ::: gtk/gtkaboutdialog.h @@ +50,3 @@ * @GTK_LICENSE_GPL_2_0: The GNU General Public License, version 2.0 or later * @GTK_LICENSE_GPL_3_0: The GNU General Public License, version 3.0 or later + * @GTK_LICENSE_AGPL_3_0: The GNU Affero General Public License, version 3.0 or later This should have a note saying: "Since: 3.22"
Created attachment 324274 [details] [review] Add support for GNU AGPL v3+, Since: 3.22
Created attachment 324276 [details] [review] Add support for GNU AGPL v3+, Since: 3.22 oops. Forgot a colon after "Since"
Created attachment 324277 [details] [review] Add support for GNU AGPL v3+, Since: 3.22 oops. Forgot a colon after "Since"
Review of attachment 324277 [details] [review]: looks good, for once we branched
Isn't this an ABI break? The enum should be added last, or all later enums will change values.
Created attachment 324749 [details] [review] Don't break ABI in GtkLicense enum (In reply to Giovanni Campagna from comment #8) > Isn't this an ABI break? > > The enum should be added last, or all later enums will change values. I don't know whether any code would rely on the value of an enum element. Anyway this patch should fix that, if required. By the way, I think that the old patch is better as it will keep the license more organized, and this patch should be reverted in Gtk4 to keep the code clean.
Created attachment 324750 [details] [review] Don't break ABI in GtkLicense enum
Review of attachment 324750 [details] [review]: yeah, thats right.
Just to clarify: this is not about 'code relying on enum values', it is simply a fact that if you compile code against gtk 3.20, it will have those values in it, simply because the compiler uses the numeric values. If you then run the app against 3.21, it will break because those numeric values now mean something else to GTK+.