Created attachment 324213 [details] [review]
GDK W32: Don't move iconic windows

Using UpdateLayeredWindow() on iconic windows brings them *back* from
their iconic (minimized) state. That is bad.
As a precaution, also don't use SetWindowPos() on iconic windows.
This means that iconic windows can't be moved. That is fixable
by using SetWindowPlacement(), but there is no pressing need to do so,
as there are very few cases when windows need to be moved while minimized.

Created attachment 324216 [details] [review]
GDK W32: Don't move iconic windows

v2:
* Removed a stray line of junk code

Review of attachment 324216 [details] [review]:

Hi LRN,

I think this patch looks and works well for me, probably you want to remove the 2 extra empty lines that I marked.

Thanks!

With blessings, and cheers!

::: gdk/win32/gdkwindow-win32.c
@@ -228,1 +227,1 @@
 

We could remove this empty line.

@@ -229,6 +228,11 @@
-  API_CALL (SetWindowPos, (GDK_WINDOW_HWND (window),
-                           SWP_NOZORDER_SPECIFIED,
-                           window_rect.left, window_rect.top,
... 3 more ...
+  if (IsIconic (GDK_WINDOW_HWND (window)))
+    {
+      GDK_NOTE (EVENTS, g_print ("Setting window position ... "));
... 8 more ...

Also this line...

Created attachment 324233 [details] [review]
GDK W32: Don't move iconic windows

v3:
* Removed empty lines
* Inverted the condition (now matches the commit message and my intent).

Review of attachment 324233 [details] [review]:

Loos ok to me.

Attachment 324233 [details] pushed as 7d2a7a5 - GDK W32: Don't move iconic windows