After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763833 - display: Separate interlaced from normal modes
display: Separate interlaced from normal modes
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
unspecified
Other All
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
: 769119 (view as bug list)
Depends on: 763832
Blocks:
 
 
Reported: 2016-03-17 19:06 UTC by Rui Matos
Modified: 2016-07-26 11:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
display: Separate interlaced from normal modes (1.80 KB, patch)
2016-03-17 19:06 UTC, Rui Matos
none Details | Review
rr: Add flags to GnomeRRMode (5.99 KB, patch)
2016-03-17 19:08 UTC, Rui Matos
none Details | Review
rr: Add API to know if a GnomeRRMode is interlaced (6.07 KB, patch)
2016-05-02 17:36 UTC, Rui Matos
committed Details | Review
display: Separate interlaced from normal modes (1.69 KB, patch)
2016-05-02 17:37 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2016-03-17 19:06:38 UTC
In bug 655041, we decided that breaking the DBus API so close to the
release wouldn't be a good idea so I'm proposing that we merge this
after we branch for 3.20 .
Comment 1 Rui Matos 2016-03-17 19:06:43 UTC
Created attachment 324209 [details] [review]
display: Separate interlaced from normal modes

https://bugzilla.gnome.org/show_bug.cgi?id=655041
Comment 2 Rui Matos 2016-03-17 19:08:16 UTC
Created attachment 324210 [details] [review]
rr: Add flags to GnomeRRMode

The corresponding gnome-desktop patch
Comment 3 Bastien Nocera 2016-03-18 11:02:37 UTC
Review of attachment 324209 [details] [review]:

::: panels/display/cc-display-panel.c
@@ +21,3 @@
 #include "cc-display-panel.h"
 
+#include <X11/extensions/randr.h>

I'd rather gnome-desktop exported a list of the compatible flags.
Comment 4 Bastien Nocera 2016-03-18 11:04:49 UTC
Review of attachment 324210 [details] [review]:

::: libgnome-desktop/gnome-rr-debug.c
@@ +26,3 @@
 
+/* From xf86drmMode.h: it's ABI so it won't change */
+#define DRM_MODE_FLAG_INTERLACE			(1<<4)

I'd rather this was exported in gnome-rr.h so we have a list of the interesting flags, or even better, a helper to get just whether something is interlaced.

::: libgnome-desktop/gnome-rr.h
@@ +185,3 @@
 double          gnome_rr_mode_get_freq_f           (GnomeRRMode           *mode);
 gboolean        gnome_rr_mode_get_is_tiled         (GnomeRRMode           *mode);
+guint32         gnome_rr_mode_get_flags            (GnomeRRMode           *mode);

I prefer:
gboolean gnome_rr_mode_get_interlaced ();

So we don't expose this implementation detail.
Comment 5 Rui Matos 2016-05-02 17:36:42 UTC
Created attachment 327176 [details] [review]
rr: Add API to know if a GnomeRRMode is interlaced

This includes a change in the DBus API which now includes the mode
flags.
Comment 6 Rui Matos 2016-05-02 17:37:11 UTC
Created attachment 327177 [details] [review]
display: Separate interlaced from normal modes
Comment 7 Bastien Nocera 2016-05-09 09:37:01 UTC
Review of attachment 327176 [details] [review]:

Looks good.
Comment 8 Bastien Nocera 2016-05-09 09:37:43 UTC
Review of attachment 327177 [details] [review]:

Looks good as well.
Comment 9 Rui Matos 2016-05-13 17:00:20 UTC
Comment on attachment 327176 [details] [review]
rr: Add API to know if a GnomeRRMode is interlaced

Attachment 327176 [details] pushed as 5ab8507 - rr: Add API to know if a GnomeRRMode is interlaced
Comment 10 Rui Matos 2016-05-13 17:01:15 UTC
Attachment 327177 [details] pushed as e9b70c2 - display: Separate interlaced from normal modes
Comment 11 Rui Matos 2016-07-26 11:27:53 UTC
*** Bug 769119 has been marked as a duplicate of this bug. ***