Created attachment 324209 [details] [review]
display: Separate interlaced from normal modes

https://bugzilla.gnome.org/show_bug.cgi?id=655041

Created attachment 324210 [details] [review]
rr: Add flags to GnomeRRMode

The corresponding gnome-desktop patch

Review of attachment 324209 [details] [review]:

::: panels/display/cc-display-panel.c
@@ +21,3 @@
 #include "cc-display-panel.h"
 
+#include <X11/extensions/randr.h>

I'd rather gnome-desktop exported a list of the compatible flags.

Review of attachment 324210 [details] [review]:

::: libgnome-desktop/gnome-rr-debug.c
@@ +26,3 @@
 
+/* From xf86drmMode.h: it's ABI so it won't change */
+#define DRM_MODE_FLAG_INTERLACE			(1<<4)

I'd rather this was exported in gnome-rr.h so we have a list of the interesting flags, or even better, a helper to get just whether something is interlaced.

::: libgnome-desktop/gnome-rr.h
@@ +185,3 @@
 double          gnome_rr_mode_get_freq_f           (GnomeRRMode           *mode);
 gboolean        gnome_rr_mode_get_is_tiled         (GnomeRRMode           *mode);
+guint32         gnome_rr_mode_get_flags            (GnomeRRMode           *mode);

I prefer:
gboolean gnome_rr_mode_get_interlaced ();

So we don't expose this implementation detail.

Created attachment 327176 [details] [review]
rr: Add API to know if a GnomeRRMode is interlaced

This includes a change in the DBus API which now includes the mode
flags.

Created attachment 327177 [details] [review]
display: Separate interlaced from normal modes

Review of attachment 327176 [details] [review]:

Looks good.

Review of attachment 327177 [details] [review]:

Looks good as well.

Comment on attachment 327176 [details] [review]
rr: Add API to know if a GnomeRRMode is interlaced

Attachment 327176 [details] pushed as 5ab8507 - rr: Add API to know if a GnomeRRMode is interlaced

Attachment 327177 [details] pushed as e9b70c2 - display: Separate interlaced from normal modes

*** Bug 769119 has been marked as a duplicate of this bug. ***