GNOME Bugzilla – Bug 763814
dot files: fix enum properties
Last modified: 2016-03-28 06:22:24 UTC
Created attachment 324187 [details] [review] rtpjitterbuffer: fix enum description for buffer mode The enum values description and names were in a wrong order
Comment on attachment 324187 [details] [review] rtpjitterbuffer: fix enum description for buffer mode Could you elaborate why you think the order should be changed? GEnumValue clearly has 'nick' as last structure member, and we use the same order elsewhere.
Created attachment 324204 [details] jitterbuffer graph In the property show in the graph we can see: "mode=((RTPJitterBufferMode) Synchronized sender and receiver clocks)" We want this instead of showing "mode=((RTPJitterBufferMode) synced)"?
Ah, I see. I think this is a problem in the dot file generation code. The thing with these enums is that GEnumValue doesn't have a field for 'description', so what we do is that for non-public enums we (ab)use the 'name' field for the description. For public enums that would typically match the enum in the header, so e.g. GstAudioSink slave-method would have: (1) skew - GST_AUDIO_BASE_SINK_SLAVE_SKEW while for non-public API it's the description. I think the dot file generation code should just always use the nick here, it's shorter and will work in both scenarios.
So, can we forget this patch and apply another one in the dot file generation?
Yes, please. Will you make a new patch?
If you do not mind, I would prefer that you do it when you can, I am sure that it will take less time for you than for me ;).
For extra fun, GstPreset has the same problem. Resulting in things like "frame-packing=Automatic (use incoming video information)" (this is from x264enc) in the generated preset files. Changing that one is more tricky as we need to keep backwards compatibility...
We should probably clone this bug for GstPreset? This should fix it for the dot files: commit 9e836805632a1da98622c13f64ba130e01e64eda Author: Tim-Philipp Müller <tim@centricular.com> Date: Sat Mar 26 17:21:51 2016 +0000 debugutils: fix enum/flag properties printing for elements We want to use the flag/enum nicks here, not only because they are shorter but also because in case of element-specific enums and flags we abuse the enum/flag name field for the description, and we don't want that printed in the dot file. https://bugzilla.gnome.org/show_bug.cgi?id=763814
Thanks Tim ;).