GNOME Bugzilla – Bug 763802
[HighContrastInverse] the “ON” text of a GtkSwitch should be black (on lightgrey)
Last modified: 2018-05-02 16:59:29 UTC
Created attachment 324164 [details] Screenshot. Using HighContrastInverse theme, the “ON” (or “1”) is for now written white on lightgrey, so hardly readable. Like with the HighContrast theme, the “ON” and the “OFF” (or “1” and “0”) should be of opposite color.
Created attachment 324688 [details] [review] High Contrast Inverse: switches - make sure both non active and active states are contrasty
Attachment 324688 [details] pushed as ac62bc0 - High Contrast Inverse: switches
I reopen, as I think that patch in fact broke both HighContrast and HighContrastInverse. GtkSwitch is not a simple toggle: it gives two informations, one about the state requested by the user (given by the position of the slider), and one about the underlying state (that should be given by the background color). Here, the background finishes with the same color whatever the underlying state is, so an information is missing.
I'm not sure what Arnaud means, but something else is off to me: * a backdropped Switch has a transparent (i.e., in HC normal, white) background * a foreground Switch has a grey background Doesn't that mean our foreground state has *less* contrast? Black-on-grey isn't a very good look.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/602.