After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763782 - Fails to build: _SVID_SOURCE is deprecated
Fails to build: _SVID_SOURCE is deprecated
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2016-03-16 19:45 UTC by Dmitry Shachnev
Modified: 2016-03-17 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Use non-deprecated feature test macros (2.05 KB, patch)
2016-03-16 21:06 UTC, Dmitry Shachnev 		committed Details | Review

Description Dmitry Shachnev 2016-03-16 19:45:28 UTC 
I can't build the current Metacity master on Debian unstable because of:

In file included from /usr/include/limits.h:25:0,
                 [...]
                 from ./include/util.h:26,
                 from core/delete.c:27:
/usr/include/features.h:148:3: error: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Werror=cpp]
 # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
   ^
cc1: all warnings being treated as errors

This is a warning, but -Werror is enabled by default so this currently makes the build fail.

Metacity defines _SVID_SOURCE in several places (keybindings.c, delete.c, main.c, window-props.c).
Comment 1 Alberts Muktupāvels 2016-03-16 19:54:30 UTC 
Can you prepare patch?

Found this in mutter, but it does not include delete.c:
https://git.gnome.org/browse/mutter/commit/?id=b159d6a5e17219557574defb6c3788d9b0c39757
Comment 3 Dmitry Shachnev 2016-03-16 21:06:45 UTC 
Created attachment 324141 [details] [review]
build: Use non-deprecated feature test macros

This works fine for me.