After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763778 - Segfault when org.freedesktop.fwupd service doesn't exist
Segfault when org.freedesktop.fwupd service doesn't exist
Status: RESOLVED OBSOLETE
Product: gnome-software
Classification: Applications
Component: General
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-16 19:07 UTC by fakey
Modified: 2016-08-15 08:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set error when org.freedesktop.fwupd has no service (960 bytes, patch)
2016-03-16 19:07 UTC, fakey 		none Details | Review
Set error when org.freedesktop.fwupd has no service (968 bytes, patch)
2016-03-24 18:44 UTC, fakey 		none Details | Review

Description fakey 2016-03-16 19:07:48 UTC 
Created attachment 324133 [details] [review]
Set error when org.freedesktop.fwupd has no service

In the fwupd plugin, gs_plugin_add_updates() can return FALSE (when org.freedesktop.fwupd service doesn't exist) without setting the error, causing a segfault. The fix is to steal the error_local and set error manually.
Comment 1 fakey 2016-03-24 18:44:33 UTC 
Created attachment 324718 [details] [review]
Set error when org.freedesktop.fwupd has no service
Comment 2 Richard Hughes 2016-08-15 08:23:12 UTC 
I think we've got new code in 3.22 for some time.