After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763768 - Wrong margin used for the sidebar separator
Wrong margin used for the sidebar separator
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Sidebar
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-16 16:09 UTC by Sebastien Bacher
Modified: 2016-04-14 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use the correct margins (879 bytes, patch)
2016-03-16 16:13 UTC, Sebastien Bacher 		reviewed Details | Review
don't set margings from the code (1.02 KB, patch)
2016-03-17 13:00 UTC, Sebastien Bacher 		none Details | Review
don't set margings from the code (1.02 KB, patch)
2016-03-17 13:00 UTC, Sebastien Bacher 		none Details | Review
don't set margings from the code (862 bytes, patch)
2016-03-17 13:01 UTC, Sebastien Bacher 		accepted-commit_now Details | Review
don't set margings from the code (986 bytes, patch)
2016-03-17 17:45 UTC, Sebastien Bacher 		accepted-commit_now Details | Review

Description Sebastien Bacher 2016-03-16 16:09:47 UTC 
Nautilus is adding separators itself before custom items in the GtkPlacesSideBar, the marging are different from the default widget ones though.
Right click on the trash for an example

That's because
https://git.gnome.org/browse/nautilus/tree/src/nautilus-window.c#n1267
uses no left/right margings

Where
https://git.gnome.org/browse/gtk+/tree/gtk/gtkplacessidebar.c?h=gtk-3-18#n3349
has 12 pixels marging

setting left/right margins to that value makes the UI consistant
Comment 1 Sebastien Bacher 2016-03-16 16:13:03 UTC 
Created attachment 324117 [details] [review]
use the correct margins
Comment 2 Carlos Soriano 2016-03-17 12:38:24 UTC 
Review of attachment 324117 [details] [review]:

Thanks Sebastien for the patch!
I talked with designers, and what we would like to do is to not set any margin, at least for now the start and end, both in gtk+ and nautilus, so themes can replace it easily.
Would you like a patch on those two situations you pointed out?
Comment 3 Sebastien Bacher 2016-03-17 13:00:27 UTC 
Created attachment 324175 [details] [review]
don't set margings from the code
Comment 4 Sebastien Bacher 2016-03-17 13:00:49 UTC 
Created attachment 324176 [details] [review]
don't set margings from the code
Comment 5 Sebastien Bacher 2016-03-17 13:01:05 UTC 
Created attachment 324177 [details] [review]
don't set margings from the code
Comment 6 Sebastien Bacher 2016-03-17 17:45:54 UTC 
Created attachment 324205 [details] [review]
don't set margings from the code

same as before but don't change top/bottom ones
Comment 7 Carlos Soriano 2016-03-18 08:20:57 UTC 
Review of attachment 324177 [details] [review]:

LGTM module the commit title missing a "set"
Comment 8 Carlos Soriano 2016-03-18 08:21:14 UTC 
Review of attachment 324205 [details] [review]:

LGTM module the commit title missing a "set".

Thanks for these patches!