After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763753 - valve: don't send sticky events as a direct response to upstream events
valve: don't send sticky events as a direct response to upstream events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal major
: 1.8.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-16 14:27 UTC by Håvard Graff (hgr)
Modified: 2016-03-25 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test and fix (7.15 KB, patch)
2016-03-16 14:27 UTC, Håvard Graff (hgr)
committed Details | Review

Description Håvard Graff (hgr) 2016-03-16 14:27:56 UTC
Created attachment 324103 [details] [review]
test and fix

Also refactor the existing valve test to actually test the valve,
and not just test the EOS mechanism of a pad.
Comment 1 Sebastian Dröge (slomo) 2016-03-24 12:53:09 UTC
commit 1bc8d9f2ea90c01aaaae5efd90a2c1819f6aa98b
Author: Havard Graff <havard.graff@gmail.com>
Date:   Wed Mar 16 15:13:39 2016 +0100

    valve: don't send sticky events as a direct response to upstream events
    
    Also refactor the existing valve test to actually test the valve,
    and not just test the EOS mechanism of a pad.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763753
Comment 2 Tim-Philipp Müller 2016-03-24 13:08:59 UTC
The unit test doesn't pass for me after this commit:

$ make elements/valve.check-norepeat
Running suite(s): valve

Unexpected critical/warning: gstpad.c:4400:gst_pad_push_data:<'':src> Got data flow before segment event
50%: Checks: 2, Failures: 1, Errors: 0
gstcheck.c:79:F:valve_basic:test_valve_basic:0: Unexpected critical/warning: gstpad.c:4400:gst_pad_push_data:<'':src> Got data flow before segment event
Comment 3 Sebastian Dröge (slomo) 2016-03-25 10:08:32 UTC
commit d9a1cb21e41744d114667d3328dfaa5f85fbaa4b
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Fri Mar 25 12:05:41 2016 +0200

    valve: Fix unit test by sending caps before buffers
    
    Unexpected critical/warning: gstpad.c:4400:gst_pad_push_data:<'':src> Got data flow before segment event
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763753