After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763733 - Crashes when running with --local-filename
Crashes when running with --local-filename
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-16 04:06 UTC by Robert Ancell
Modified: 2016-03-17 12:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Robert Ancell 2016-03-16 04:06:34 UTC 
If you run:
$ gnome-software --local-filename=<some file>

it crashes inside gs_app_get_quirk. This is because app is NULL and there is no check inside this function (the others have the checks).
Comment 1 Robert Ancell 2016-03-16 04:07:31 UTC 
I think the NULL app is an existing problem that might have been exposed with a recent code change. In master I added the checks to gs_app_get|has_quirk but this doesn't resolve the actual issue (why is app NULL).
Comment 2 Richard Hughes 2016-03-16 10:00:54 UTC 
I think this should fix things:

commit f6a9179f5b24d5bf59c478a925c6de95ab108611
Author: Richard Hughes <richard@hughsie.com>
Date:   Wed Mar 16 09:46:28 2016 +0000

    Fix a crash when double clicking package files
    
    This is caused by a call to gs_shell_details_switch_to() before the
    filename_to_app() plugin function has run. We call gs_shell_details_switch_to()
    manually after completing this task so ignoring the first refresh is the right
    thing to do.
    
    Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=763733

If you can verify then I'll get release-team acks.
Comment 3 Robert Ancell 2016-03-16 20:04:42 UTC 
Confirmed - this fixes the issue.
Comment 4 Richard Hughes 2016-03-17 12:54:08 UTC 
Pushed to gnome-3-20