GNOME Bugzilla – Bug 763712
Use G_DECLARE_FINAL_TYPE for final classes
Last modified: 2017-09-27 02:50:27 UTC
We should switch to using G_DECLARE_FINAL_TYPE for all final classes (ie. classes without a private structure). See https://wiki.gnome.org/HowDoI/SubclassGObject for further details. Please use a separate patch for each class to keep it manageable.
Created attachment 330752 [details] [review] photos-embed : Use G_DECLARE_FINAL_TYPE for PhotosEmbed class In this commit, we are using G_DECLARE_FINAL_TYPE, as the PhotosEmbed class has not been further subclassed. https://bugzilla.gnome.org/show_bug.cgi?id=763712
Review of attachment 330752 [details] [review]: Thanks for the patch, Shivam. The commit message needs some work. See: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Submitting_patches https://wiki.gnome.org/Git/CommitMessages Also, can you please capitalize your name properly as in the other git commits. I mention this because it shows up in the UI (specifically the about dialog). A few other comments: ::: src/photos-embed.h @@ +35,2 @@ #define PHOTOS_TYPE_EMBED (photos_embed_get_type ()) Nitpick: this newline is no longer needed. @@ -40,1 +38,1 @@ Ditto. @@ +40,1 @@ typedef struct _PhotosEmbed PhotosEmbed; This typedef shouldn't be needed. Any reason you kept it?
Created attachment 330756 [details] [review] photos-embed : Use G_DECLARE_FINAL_TYPE with the class Use G_DECLARE_FINAL_TYPE with the class, as it has no private structure and has not been further subclassed.
Review of attachment 330756 [details] [review]: This is much better. The commit message shouldn't exceed 72 characters per line, though. I forgot to mention that we should bump the GLib requirement in configure.ac to 2.44.0. ::: src/photos-embed.h @@ +35,2 @@ #define PHOTOS_TYPE_EMBED (photos_embed_get_type ()) We still have a needless newline here.
Created attachment 330757 [details] [review] embed: Use G_DECLARE_FINAL_TYPE I took the liberty to fix it up.
Created attachment 330798 [details] [review] base-model: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Ok I missed typedef again. I am sending a new patch.
Created attachment 330799 [details] [review] base-model: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Review of attachment 330799 [details] [review]: Are you sure you attached a new patch? :) This is the same as attachment 330798 [details] [review]. ::: src/photos-base-model.h @@ +37,1 @@ typedef struct _PhotosBaseModel PhotosBaseModel; We don't need this typedef either.
Created attachment 330993 [details] [review] base-model: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 330995 [details] [review] camera_cache: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Review of attachment 330993 [details] [review]: ::: src/photos-base-model.h @@ +34,2 @@ #define PHOTOS_TYPE_BASE_MODEL (photos_base_model_get_type ()) +G_DECLARE_FINAL_TYPE(PhotosBaseModel, photos_base_model, PHOTOS, BASE_MODEL, GObject) Nitpick: would be nice to have a whitespace before the opening parenthesis like we have elsewhere.
Created attachment 331007 [details] [review] base-model: Use G_DECLARE_FINAL_TYPE Added the whitespace and pushed to master.
Review of attachment 330995 [details] [review]: Thanks for the patches, Shivam. ::: src/photos-camera-cache.h @@ +29,2 @@ #define PHOTOS_TYPE_CAMERA_CACHE (photos_camera_cache_get_type ()) +G_DECLARE_FINAL_TYPE(PhotosCameraCache, photos_camera_cache, PHOTOS, CAMERA_CACHE, GObject) Nitpick: a whitespace before the opening parenthesis would be nice.
Created attachment 331008 [details] [review] camera-cache: Use G_DECLARE_FINAL_TYPE Pushed to master after adding the whitespace.
Created attachment 331016 [details] [review] create_collection_icon_job: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 331018 [details] [review] create_collection_job: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 331019 [details] [review] delete_item_job: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 331020 [details] [review] dlna_renderers_dialog: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 331021 [details] [review] dlna_renderers_manager: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Review of attachment 331016 [details] [review]: Thanks for the nice patch, Shivam. It looks very good except a small niggle with the commit message. Don't use underscores. Instead, uses dashes. See the other commit messages for examples.
Created attachment 331022 [details] [review] done_notification: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 331023 [details] [review] dropdown: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
I'll switch to dashes from now on. Do I need to resend the patches?
Review of attachment 331016 [details] [review]: Re-sending, with dash.
Created attachment 331024 [details] [review] create-collection-icon-job: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 331025 [details] [review] create-collection-job: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 331026 [details] [review] delete-item-job: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 331027 [details] [review] dlna-renderers-dialog: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 331028 [details] [review] dlna-renderers-manager: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 331029 [details] [review] done-notification: Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Review of attachment 331025 [details] [review]: ::: src/photos-create-collection-job.h @@ +34,1 @@ Nitpick: an extra newline left behind.
Created attachment 331033 [details] [review] create-collection-job: Use G_DECLARE_FINAL_TYPE Fixed and pushed to master.
Review of attachment 331024 [details] [review]: ::: src/photos-create-collection-icon-job.h @@ +32,2 @@ #define PHOTOS_TYPE_CREATE_COLLECTION_ICON_JOB (photos_create_collection_icon_job_get_type ()) +G_DECLARE_FINAL_TYPE (PhotosCreateCollectionIconJob, photos_create_collection_icon_job, PHOTOS, CREATE_COLLECTION_ICON_JOB, GObject) This line is a bit too long. We do go upto 120 characters per line, but this more than that. @@ +34,1 @@ Nitpick: extra newline left behind. @@ +36,2 @@ typedef void (*PhotosCreateCollectionIconJobCallback) (GIcon *, gpointer); Ditto.
Created attachment 331053 [details] [review] create-collection-icon-job: Use G_DECLARE_FINAL_TYPE Fixed it up and pushed to master.
Review of attachment 331023 [details] [review]: ::: src/photos-dropdown.h @@ +34,1 @@ Nitpick: extra newline here.
Review of attachment 331026 [details] [review]: ::: src/photos-delete-item-job.h @@ +34,1 @@ Nitpick: extra newline here.
Created attachment 331127 [details] [review] dropdown: Use G_DECLARE_FINAL_TYPE Fixed and pushed to master.
Created attachment 331302 [details] [review] delete-item-job: Use G_DECLARE_FINAL_TYPE
Created attachment 331303 [details] [review] dlna-renderers-dialog: Use G_DECLARE_FINAL_TYPE
Created attachment 331304 [details] [review] dlna-renderers-manager: Use G_DECLARE_FINAL_TYPE
Created attachment 331308 [details] [review] done-notification: Use G_DECLARE_FINAL_TYPE
Review of attachment 331308 [details] [review]: ::: src/photos-done-notification.h @@ -42,3 @@ -GType photos_done_notification_get_type (void) G_GNUC_CONST; - -void photos_done_notification_new (PhotosBaseItem *item); it should keep _new() otherwise it fails to compile: photos-done-notification.c:268:1: error: no previous prototype for ‘photos_done_notification_new’ [-Werror=missing-prototypes] photos_done_notification_new (PhotosBaseItem *item) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors
(In reply to Pavel Grunt from comment #43) > Review of attachment 331308 [details] [review] [review]: > > ::: src/photos-done-notification.h > @@ -42,3 @@ > -GType photos_done_notification_get_type (void) G_GNUC_CONST; > - > -void photos_done_notification_new (PhotosBaseItem *item); > > it should keep _new() You are absolutely right. I should have noticed it during the review. Thanks for catching it, Pavel!
Created attachment 331378 [details] [review] done-notification: Restore the photos_done_notification_new declaration
Created attachment 334294 [details] [review] error-box : Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Created attachment 334295 [details] [review] empty-results-box : Use G_DECLARE_FINAL_TYPE Use G_DECLARE_FINAL_TYPE, as class is not further subclassed.
Review of attachment 334294 [details] [review]: Thanks, Shivam. Pushed. Nitpick: we can omit the body of the commit message here because it is quite obvious.
Review of attachment 334295 [details] [review]: Thanks. Looks good. Pushed.
Created attachment 336970 [details] [review] application: Remove the pointer for the object method signal handler
Created attachment 336971 [details] [review] application: Use G_DECLARE_FINAL_TYPE
Created attachment 337052 [details] [review] local-item: Use G_DECLARE_FINAL_TYPE
Created attachment 337053 [details] [review] facebook-item: Use G_DECLARE_FINAL_TYPE
Created attachment 337054 [details] [review] flickr-item: Use G_DECLARE_FINAL_TYPE
Created attachment 337055 [details] [review] google-item: Use G_DECLARE_FINAL_TYPE
Created attachment 337056 [details] [review] media-server-item: Use G_DECLARE_FINAL_TYPE
Created attachment 337124 [details] [review] collection-icon-watcher: Remove the vfunc for the default handler
Created attachment 337126 [details] [review] collection-icon-watcher: Use G_DECLARE_FINAL_TYPE
Created attachment 337127 [details] [review] delete-notification: Use G_DECLARE_FINAL_TYPE
Created attachment 337528 [details] [review] widget-shader: Use G_DECLARE_FINAL_TYPE
Created attachment 337529 [details] [review] dlna-renderer: Use G_DECLARE_FINAL_TYPE
Created attachment 340243 [details] [review] edit-palette: Remove the pointer for the object method signal handler
Created attachment 340244 [details] [review] edit-palette: Use G_DECLARE_FINAL_TYPE
Created attachment 340245 [details] [review] view-model: Use G_DECLARE_FINAL_TYPE
Created attachment 340246 [details] [review] edit-palette-row: Use G_DECLARE_FINAL_TYPE
Created attachment 340247 [details] [review] export-dialog: Use G_DECLARE_FINAL_TYPE
Created attachment 340248 [details] [review] view-container: Use G_DECLARE_FINAL_TYPE
Created attachment 340249 [details] [review] export-notification: Use G_DECLARE_FINAL_TYPE
Created attachment 340509 [details] [review] update-mtime-job: Use G_DECLARE_FINAL_TYPE
Created attachment 340510 [details] [review] image-view: Remove the pointers for the object method signal handlers
Created attachment 340825 [details] [review] fetch-collection-state-job: Use G_DECLARE_FINAL_TYPE
Created attachment 340826 [details] [review] fetch-collections-job: Use G_DECLARE_FINAL_TYPE
Created attachment 340827 [details] [review] fetch-ids-job: Use G_DECLARE_FINAL_TYPE
Created attachment 340828 [details] [review] fetch-metas-job: Use G_DECLARE_FINAL_TYPE
Created attachment 340829 [details] [review] image-view: Use G_DECLARE_FINAL_TYPE
Created attachment 340843 [details] [review] notification-manager: Use G_DECLARE_FINAL_TYPE
Created attachment 340967 [details] [review] header-bar: Use G_DECLARE_FINAL_TYPE
Created attachment 342900 [details] [review] preview-nav-buttons: Use G_DECLARE_FINAL_TYPE
Created attachment 342901 [details] [review] tool-crop: Use G_DECLARE_FINAL_TYPE
Created attachment 342902 [details] [review] tool-colors: Use G_DECLARE_FINAL_TYPE
Created attachment 342903 [details] [review] tool-enhance: Use G_DECLARE_FINAL_TYPE
Created attachment 342904 [details] [review] tool-filters: Use G_DECLARE_FINAL_TYPE
Created attachment 345292 [details] [review] indexing-notification: Use G_DECLARE_FINAL_TYPE
Created attachment 345293 [details] [review] organize-collection-dialog: Use G_DECLARE_FINAL_TYPE
Created attachment 345924 [details] [review] tracker-overview-controller: Use G_DECLARE_FINAL_TYPE
Created attachment 345925 [details] [review] tracker-queue: Use G_DECLARE_FINAL_TYPE
Created attachment 345926 [details] [review] tracker-search-controller: Use G_DECLARE_FINAL_TYPE
Created attachment 345927 [details] [review] item-manager: Remove the pointers for the object method signal handlers
Created attachment 345928 [details] [review] item-manager: Use G_DECLARE_FINAL_TYPE
Created attachment 346895 [details] [review] pipeline: Use G_DECLARE_FINAL_TYPE
Created attachment 346896 [details] [review] main-toolbar: Use G_DECLARE_FINAL_TYPE
Created attachment 346897 [details] [review] main-window: Use G_DECLARE_FINAL_TYPE
Created attachment 347031 [details] [review] offset-collections-controller: Use G_DECLARE_FINAL_TYPE
Created attachment 347032 [details] [review] offset-favorites-controller: Use G_DECLARE_FINAL_TYPE
Created attachment 347991 [details] [review] offset-overview-controller: Use G_DECLARE_FINAL_TYPE
Created attachment 347992 [details] [review] offset-search-controller: Use G_DECLARE_FINAL_TYPE
Created attachment 348064 [details] [review] operation-insta-curve: Use G_DECLARE_FINAL_TYPE
Created attachment 348065 [details] [review] operation-insta-filter: Use G_DECLARE_FINAL_TYPE
Created attachment 348066 [details] [review] operation-insta-hefe-curve: Use G_DECLARE_FINAL_TYPE
Created attachment 348379 [details] [review] gegl: Add autocleanups for GeglOperation and its relevant sub-classes
Created attachment 348380 [details] [review] operation-insta-curve: Use G_DECLARE_FINAL_TYPE
Created attachment 348381 [details] [review] operation-insta-filter: Use G_DECLARE_FINAL_TYPE
Created attachment 348382 [details] [review] operation-insta-hefe-curve: Use G_DECLARE_FINAL_TYPE
Created attachment 348383 [details] [review] operation-insta-hefe-vignette: Use G_DECLARE_FINAL_TYPE
Created attachment 348384 [details] [review] operation-insta-hefe: Use G_DECLARE_FINAL_TYPE
Created attachment 348385 [details] [review] operation-jpg-guess-sizes: Use G_DECLARE_FINAL_TYPE
Created attachment 348386 [details] [review] operation-png-guess-sizes: Use G_DECLARE_FINAL_TYPE
Created attachment 348387 [details] [review] operation-saturation: Use G_DECLARE_FINAL_TYPE
Created attachment 348531 [details] [review] photos-search-type: Use-G_DECLARE_FINAL_TYPE
Review of attachment 348531 [details] [review]: Thanks for the patch, Rashi. Looks quite good apart from some small problems. The commit message needs to be tweaked a bit. We don't use the "photos-" prefix in the summary because it is implied. Did you, by chance, mis-spell your name? I am asking because it automatically gets added to app-menu -> help -> about -> credits and is visible in the UI. ::: src/photos-search-type.h @@ -48,3 @@ -typedef struct _PhotosSearchTypeClass PhotosSearchTypeClass; - -GType photos_search_type_get_type (void) G_GNUC_CONST; We also need to remove the definition of 'struct _PhotosSearchTypeClass' from src/photos-search-type.c. See the other patches for examples. Or did you find a similar mistake in one of them?
Created attachment 348668 [details] [review] search-type: Use-G_DECLARE_FINAL_TYPE
No, I did not misspell my name. Isn't it showing the name as 'Rashi'?
Created attachment 348673 [details] [review] search-type: Use-G_DECLARE_FINAL_TYPE
(In reply to Rashi from comment #112) > No, I did not misspell my name. Isn't it showing the name as 'Rashi'? Come on. You don't know how it is showing in the patch that you wrote?! It's showing up as 'RashiSah'. If that's how you spell it, then it's fine. I just wanted to be sure that we have the correct spelling.
Yeah, I am sorry! I write my name as Rashi Sah. This has been misspelled, I need to change it.
Review of attachment 348379 [details] [review]: These are no longer needed and have been removed. See bug 782012
Review of attachment 348668 [details] [review]: I was hoping that you'd at least fix the spelling of your name. Never mind the fact that this patch doesn't build. :( ::: src/photos-search-type.h @@ +32,2 @@ #define PHOTOS_TYPE_SEARCH_TYPE (photos_search_type_get_type ()) +G_DECLARE_FINAL_TYPE (PhotosSearchtype, photos_search_type, PHOTOS, SEARCH_TYPE, GObject); Typo: *PhotosSearchType* @@ -43,3 @@ -#define PHOTOS_SEARCH_TYPE_STOCK_COLLECTIONS "collections" -#define PHOTOS_SEARCH_TYPE_STOCK_FAVORITES "favorites" -#define PHOTOS_SEARCH_TYPE_STOCK_PHOTOS "photos" These 4 preprocessor macros are needed. They are not part of the GObject boilerplate. Removing them will break the build.
Created attachment 351475 [details] [review] search-type: Use G_DECLARE_FINAL_TYPE
Created attachment 353864 [details] [review] organize-collection-model: Use G_DECLARE_FINAL_TYPE
Created attachment 355811 [details] [review] organize-collection-view: Use G_DECLARE_FINAL_TYPE
Created attachment 355812 [details] [review] print-notification: Use G_DECLARE_FINAL_TYPE
Created attachment 359103 [details] [review] tracker-favorites-controller: Use G_DECLARE_FINAL_TYPE
Created attachment 359104 [details] [review] tracker-collections-controller: Use G_DECLARE_FINAL_TYPE
Created attachment 359105 [details] [review] tool-filter-button: Use G_DECLARE_FINAL_TYPE
Created attachment 359106 [details] [review] spinner-box: Use G_DECLARE_FINAL_TYPE
Created attachment 359107 [details] [review] source-manager: Use G_DECLARE_FINAL_TYPE
Created attachment 359116 [details] [review] source: Use G_DECLARE_FINAL_TYPE
Created attachment 359117 [details] [review] single-item-job: Use G_DECLARE_FINAL_TYPE
Created attachment 359118 [details] [review] share-point-manager: Use G_DECLARE_FINAL_TYPE
Created attachment 359119 [details] [review] share-dialog: Use G_DECLARE_FINAL_TYPE
Created attachment 359120 [details] [review] set-collection-job: Use G_DECLARE_FINAL_TYPE
Created attachment 359121 [details] [review] print-setup: Use G_DECLARE_FINAL_TYPE Move some code around (from .h to .c) , please lookout!
Created attachment 359124 [details] [review] preview-view: Use G_DECLARE_FINAL_TYPE
Created attachment 359125 [details] [review] print-operation: Use G_DECLARE_FINAL_TYPE
Created attachment 359126 [details] [review] print-preview: Use G_DECLARE_FINAL_TYPE Move some code around (from .h to .c) , please lookout!
Created attachment 359128 [details] [review] print-preview: Use G_DECLARE_FINAL_TYPE
Created attachment 359129 [details] [review] remote-display-manager: Use G_DECLARE_FINAL_TYPE
Created attachment 359130 [details] [review] search-match: Use G_DECLARE_FINAL_TYPE
Created attachment 359131 [details] [review] search-match-manager: Use G_DECLARE_FINAL_TYPE
Created attachment 359132 [details] [review] search-provider: Use G_DECLARE_FINAL_TYPE
Created attachment 359133 [details] [review] search-type-manager: Use G_DECLARE_FINAL_TYPE
Created attachment 359134 [details] [review] selection-toolbar: Use G_DECLARE_FINAL_TYPE
Created attachment 359139 [details] [review] overview-searchbar: Use G_DECLARE_FINAL_TYPE
Review of attachment 359103 [details] [review]: Thanks for the patches! Looks good to me.
Review of attachment 359104 [details] [review]: ++ By the way, do you have a GNOME Git account?
Review of attachment 359105 [details] [review]: ::: src/photos-tool-filter-button.h @@ +31,3 @@ + PHOTOS, + TOOL_FILTER_BUTTON, + GtkBin); Nitpick: Could be on the same line.
Created attachment 359162 [details] [review] tool-filter-button: Use G_DECLARE_FINAL_TYPE Fixed and pushed.
Review of attachment 359106 [details] [review]: ::: src/photos-spinner-box.h @@ +35,3 @@ + PHOTOS, + SPINNER_BOX, + GtkRevealer); Nitpick: could be on the same line.
Created attachment 359168 [details] [review] spinner-box: Use G_DECLARE_FINAL_TYPE
Created attachment 359225 [details] [review] selection-controller: Remove the vfunc for the default handler
Created attachment 359226 [details] [review] selection-controller: Use G_DECLARE_FINAL_TYPE
Created attachment 359227 [details] [review] search-controller: Remove the vfunc for the default handler
Created attachment 359228 [details] [review] search-controller: Use G_DECLARE_FINAL_TYPE
Created attachment 359229 [details] [review] properties-dialog: Remove the vfunc for the default handler
Created attachment 359230 [details] [review] properties-dialog: Use G_DECLARE_FINAL_TYPE
Created attachment 359231 [details] [review] tracker-change-monitor: Remove the vfunc for the default handler
Created attachment 359232 [details] [review] tracker-change-monitor: Use G_DECLARE_FINAL_TYPE
Review of attachment 359107 [details] [review]: Thanks, Umang. Looks good to me.
Review of attachment 359116 [details] [review]: Perfect, looks good.
Review of attachment 359117 [details] [review]: ::: src/photos-single-item-job.h @@ -51,1 @@ Nitpick: extra newline left behind.
Review of attachment 359118 [details] [review]: ++
Created attachment 359251 [details] [review] single-item-job: Use G_DECLARE_FINAL_TYPE Removed the extra newline and pushed.
Review of attachment 359119 [details] [review]: ++
Review of attachment 359120 [details] [review]: ++
Review of attachment 359107 [details] [review]: Committed
Review of attachment 359116 [details] [review]: Committed
Review of attachment 359118 [details] [review]: committed
Review of attachment 359119 [details] [review]: committed
Review of attachment 359120 [details] [review]: committed
Review of attachment 359121 [details] [review]: This isn't quite right. First, we need to turn PrintSetup into a final class by dropping the priv pointer. eg., commit 56802826f5f21c46. Then we need to use G_DECLARE_FINAL_TYPE.
Review of attachment 359124 [details] [review]: Looks good to me.
Review of attachment 359125 [details] [review]: ++
Review of attachment 359126 [details] [review]: Oops! The PrintPreview class is messy. We inherited it from Eye of GNOME, and the coding style doesn't match the rest of the codebase. Similar to attachment 359121 [details] [review], first, we need to turn PrintPreview into a final class by dropping the priv pointer. eg., commit 56802826f5f21c46. Then we need to use G_DECLARE_FINAL_TYPE. I took the liberty to fix up some of the style issues. If you do want to fix any of the remaining style issues, please keep them in a separate patch. :)
Review of attachment 359129 [details] [review]: ++
Review of attachment 359130 [details] [review]: ++
Review of attachment 359131 [details] [review]: ::: src/photos-search-match-manager.h @@ +33,2 @@ #define PHOTOS_TYPE_SEARCH_MATCH_MANAGER (photos_search_match_manager_get_type ()) +G_DECLARE_FINAL_TYPE (PhotosSearchMatchManager, photos_search_match_manager, PHOTOS, SEARCH_MATCH_MANAGER, PhotosBaseManager); This seems a little too close to the edge for comfort. If 120 is the hard limit, it is better to keep one or two characters as margin. Helpful when looking at diffs with the +/-/etc. in the gutter. Anyway, that's a very minor personal niggle of mine. :)
Created attachment 359377 [details] [review] search-match-manager: Use G_DECLARE_FINAL_TYPE Fixed and pushed.
Review of attachment 359124 [details] [review]: committed
Review of attachment 359125 [details] [review]: committed
Review of attachment 359129 [details] [review]: committed
Review of attachment 359130 [details] [review]: committed
Review of attachment 359132 [details] [review]: Looks good to me, thanks!
Review of attachment 359133 [details] [review]: ::: src/photos-search-type-manager.h @@ +32,2 @@ #define PHOTOS_TYPE_SEARCH_TYPE_MANAGER (photos_search_type_manager_get_type ()) +G_DECLARE_FINAL_TYPE (PhotosSearchTypeManager, photos_search_type_manager, PHOTOS, SEARCH_TYPE_MANAGER, PhotosBaseManager); This seems a little too close to the edge for comfort. If 120 is the hard limit, it is better to keep one or two characters as margin. Helpful when looking at diffs with the +/-/etc. in the gutter. Anyway, that's a very minor personal niggle of mine. :)
Created attachment 359412 [details] [review] search-type-manager: Use G_DECLARE_FINAL_TYPE
Review of attachment 359134 [details] [review]: Looks good. Thank you.
Comment on attachment 359134 [details] [review] selection-toolbar: Use G_DECLARE_FINAL_TYPE I pushed this myself by mistake.
Review of attachment 359139 [details] [review]: ++
Review of attachment 359225 [details] [review]: Looks good to me.
Review of attachment 359226 [details] [review]: ::: src/photos-selection-controller.h @@ +32,2 @@ #define PHOTOS_TYPE_SELECTION_CONTROLLER (photos_selection_controller_get_type ()) +G_DECLARE_FINAL_TYPE (PhotosSelectionController, photos_selection_controller, PHOTOS, SELECTION_CONTROLLER, GObject) Nitpick: missing semi-colon.
Created attachment 359697 [details] [review] selection-controller: Use G_DECLARE_FINAL_TYPE Fixed and pushed.
Review of attachment 359227 [details] [review]: Perfect.
Review of attachment 359228 [details] [review]: ++
Comment on attachment 359228 [details] [review] search-controller: Use G_DECLARE_FINAL_TYPE I pushed this to master.
Created attachment 360417 [details] [review] overview-searchbar: Use G_DECLARE_FINAL_TYPE
Review of attachment 359229 [details] [review]: ++
Review of attachment 359230 [details] [review]: Looks good. Thanks.
Review of attachment 359231 [details] [review]: ++
Review of attachment 359232 [details] [review]: ++
Created attachment 360472 [details] [review] print-preview: Use G_DECLARE_FINAL_TYPE
Created attachment 360473 [details] [review] print-setup: Use G_DECLARE_FINAL_TYPE
Review of attachment 360472 [details] [review]: ++
Review of attachment 360473 [details] [review]: ++