After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763631 - Folder->Subscriptions opened empty with gtk+3.19.11
Folder->Subscriptions opened empty with gtk+3.19.11
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.19.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2016-03-14 17:50 UTC by Yanko Kaneti
Modified: 2016-03-14 18:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Empty dialog (27.25 KB, image/png)
2016-03-14 17:50 UTC, Yanko Kaneti
  Details
proposed evo patch (956 bytes, patch)
2016-03-14 17:53 UTC, Milan Crha
accepted-commit_after_freeze Details | Review
proposed evo patch ][ (959 bytes, patch)
2016-03-14 18:17 UTC, Milan Crha
committed Details | Review

Description Yanko Kaneti 2016-03-14 17:50:17 UTC
Created attachment 323899 [details]
Empty dialog

See attachment

evolution-3.19.92-1.fc25.x86_64
evolution-data-server-3.19.92-1.fc25.x86_64
Comment 1 Milan Crha 2016-03-14 17:53:43 UTC
Created attachment 323900 [details] [review]
proposed evo patch

for evolution;

Please give a try to this patch.
Comment 2 Milan Crha 2016-03-14 17:56:44 UTC
The problem is with the gtk+ 3.19.11, not with gtk 3.18.6. It seems like the "changed" callback is called too early on the combobox, which is also shown on the console:

> (evolution:2398): evolution-mail-CRITICAL **:
> subscription_editor_combo_box_changed_cb: assertion 'index < editor->priv->stores->len' failed

Then the callbacks do not trigger as expected and everything breaks after it.
Comment 3 Yanko Kaneti 2016-03-14 18:12:11 UTC
The proposed patch works for me.
Comment 4 Milan Crha 2016-03-14 18:17:35 UTC
Created attachment 323901 [details] [review]
proposed evo patch ][

for evolution;

The previous patch has a copy&paste error in it, which this one corrects.
Comment 5 Milan Crha 2016-03-14 18:43:08 UTC
I've got an approval from the release team, thus:

Created commit be0f25b in master (3.20.0+)