GNOME Bugzilla – Bug 763623
CSS runtime warning
Last modified: 2016-03-16 17:47:11 UTC
There is one run-time warning. (org.gnome.Polari:22033): Gtk-WARNING **: Theme parsing error: application.css:18:30: The style property GtkWidget:focus-padding is deprecated and shouldn't be used anymore. It will be removed in a future version --- To fix this we should remove 'GtkWidget-focus-padding' and use the CSS standard 'padding' property instead. I
Created attachment 323878 [details] [review] Proposed patch
Review of attachment 323878 [details] [review]: > To fix this we should remove 'GtkWidget-focus-padding' and use the CSS > standard 'padding' property instead. No, that replacement is not correct. The former used to affect the focus indication (that dotted rectangle when tab'ing around the interface), while the standard padding affects the content box.
This is the recommended solution seen in GNOME docs - https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--s-focus-padding And, it seems to work as expected. Well, maybe I failed to see the differences.
(In reply to Claudio André from comment #3) > This is the recommended solution seen in GNOME docs > - > https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--s-focus- > padding Yet when updating Adwaita itself[0], the property was not replaced ... [0] https://git.gnome.org/browse/gtk+/commit?id=e24c248013b6d6698
The correct replacement would be outline-offset, I guess
I'm leaving this to you guys. The best I can think is something like this: .polari-user-list row { padding: 0px outline: 1px dotted gray; outline-offset: 0px; } BTW: default value of outline-offset is zero.
To be honest, I don't quite remember why the property is there in the first place (git-blame points to me, but I suspect that the style part was done by Jakub). Let's just remove it to get rid of the warning, and let the designers come up with fixes for anything they think needs fixing ...