GNOME Bugzilla – Bug 763618
README instruction is outdated
Last modified: 2016-04-04 14:54:38 UTC
I followed the steps in the README to build gnome-music. However the README is outdated. The README should instruct the user to use jhbuild to build gnome-music.
Created attachment 324531 [details] [review] Updated README to instruct newcomers using jhbuild I changed the README to instruct newcomers using jhbuild for building GNOME Music. Hope this is appropriate.
Created attachment 324548 [details] [review] Updated README to instruct newcomers using jhbuild
Created attachment 324863 [details] [review] Instruct newcomers using jhbuild for building Using git format-patch when generating patch.
Review of attachment 324863 [details] [review]: Thanks for the patch. needs-work. ::: README @@ +20,3 @@ https://wiki.gnome.org/Newcomers/BuildGnome +After installing jhbuild, run "jhbuild build gnome-music" to build gnome-music and all its dependeicies. You misspelled "dependencies".
Created attachment 325293 [details] Instruct newcomers using jhbuild for building Fixed the mispell
Created attachment 325299 [details] [review] Instruct newcomers using jhbuild for building gnome The last patch does not include all the changes.
Review of attachment 325299 [details] [review]: ::: README @@ +18,1 @@ +GNOME Music is best built with jhbuild. Please followed the BuildGnome tutorial for newcomers closely. I would rather have something like "Follow the BuildGnome tutorial for newcomers at https://wiki.gnome.org/Newcomers/BuildGnome" @@ +21,3 @@ + +After installing jhbuild, run "jhbuild build gnome-music" to build gnome-music and all its dependencies. +Finally, start gnome music with "jhbuild run gnome-music" These steps could have been itemized. For instance: After installing jhbuild, run: $ jhbuild build gnome-music ...
Created attachment 325338 [details] [review] Instruct newcomers using jhbuild for building gnome * Itemized the steps for building and running gnome-music * Change some sentences.
Review of attachment 325338 [details] [review]: ::: README @@ +20,1 @@ +After installing jhbuild, you have to build gnome-music and all its dependeicies. The task can be done by simply running: dependencies.
Created attachment 325344 [details] [review] Instruct newcomers using jhbuild for building gnome Fixed the typo ><
Created attachment 325345 [details] [review] Instruct newcomers using jhbuild for building gnome Uploaded the updated version. sorry ><
Review of attachment 325345 [details] [review]: ok.
Thanks for your patch.
Hey, this instructions tend to be outdated fairly easy. I suggest to just link to https://wiki.gnome.org/Newcomers/BuildGnome as you did, but don't specify more steps. Just my 2 cents :)