GNOME Bugzilla – Bug 763617
giotypefuncs.c: Sort _get_type functions in the 'C' locale
Last modified: 2016-03-21 13:46:48 UTC
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812876 Fixing this makes glib's build reproducible.
Created attachment 323869 [details] [review] giotypefuncs.c: Sort _get_type functions in the 'C' locale This ensures that the generated file is always the same (not dependent on the build machine's environment), making the build reproducible. Thanks to Jérémy Bobbio <lunar@debian.org> for the Debian bug report and patch.
Review of attachment 323869 [details] [review]: Looks harmless enough, but I wonder if patching fixed locales into shell fragments buried in Makefiles is a scalable approach to this problem. Wouldn't a fixed environment the first thing one starts with when going after a 'reproducible build' ? I mean, I would expect e.g. koji to run its builds in C (or en_US.utf8).
It's not really my project, but I think that the idea is that you can run the build in any reasonable environment—capturing as little as possible—and get the same result. See: https://reproducible-builds.org/docs/deterministic-build-systems/ They run automated rebuilds of packages to detect when unreproducibility creeps in so we have a decent chance of keeping up.
Review of attachment 323869 [details] [review]: imho, this fragment is already ridiculous and this makes it no worse. If this is the one issue that we need to fix in order to get reproducible builds, I'm happy to see it done.
The following fix has been pushed: a668ee8 giotypefuncs.c: Sort _get_type functions in the 'C' locale
Created attachment 324434 [details] [review] giotypefuncs.c: Sort _get_type functions in the 'C' locale This ensures that the generated file is always the same (not dependent on the build machine's environment), making the build reproducible. Thanks to Jérémy Bobbio <lunar@debian.org> for the Debian bug report and patch.