After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763612 - [HighContrast(|Inverse)] “:selected .circular” should be visible
[HighContrast(|Inverse)] “:selected .circular” should be visible
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-03-14 12:35 UTC by Arnaud B.
Modified: 2016-03-17 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot. All rows have a close button with “circular” class, including the one selected. (24.87 KB, image/png)
2016-03-14 12:35 UTC, Arnaud B. 		  Details
High Contrast: circular buttons (2.43 KB, patch)
2016-03-16 13:56 UTC, Jakub Steiner 		committed Details | Review
Screenshot. (26.45 KB, image/png)
2016-03-17 09:44 UTC, Arnaud B. 		  Details
works in git master (52.22 KB, image/png)
2016-03-17 15:05 UTC, Jakub Steiner 		  Details

Description Arnaud B. 2016-03-14 12:35:01 UTC 
Created attachment 323863 [details]
Screenshot. All rows have a close button with “circular” class, including the one selected.

When using HighContrast/HighContrastInverse themes, a button with the “circular” CSS class should be visible on a selected GtkListBoxRow, so should have a white color with HighContrast theme (but black when hovered…) and opposite with HighContrastInverse.
Comment 1 Jakub Steiner 2016-03-16 13:56:19 UTC 
Created attachment 324101 [details] [review]
High Contrast: circular buttons

- make sure they are visible on selected rows
Comment 2 Jakub Steiner 2016-03-16 13:57:17 UTC 
Attachment 324101 [details] pushed as b73f428 - High Contrast: circular buttons
Comment 3 Arnaud B. 2016-03-17 09:44:21 UTC 
Created attachment 324160 [details]
Screenshot.

I reopen, as the bug is not solved for `dconf-editor`: the button doesn’t contain a “label” node, but a symbolic icon (“image” node); so, the cross color is not adjusted, the button finishes all white (it’s white on white).
Comment 4 Arnaud B. 2016-03-17 09:49:36 UTC 
I just realised that these buttons also have the “flat” class, so the “circular” things only show on hover with Adwaita. The inspector shows that removing this class doesn’t change this bug, but it might change the needed solution. Also, that behaviour is not important for `dconf-editor`, but that’s technically another bug that the “flat” class does nothing here.
Comment 5 Jakub Steiner 2016-03-17 15:05:15 UTC 
Created attachment 324191 [details]
works in git master