Created attachment 323855 [details] [review]
afc: Fix accessing applications with HouseArrest

Only sideloaded applications (development versions for example) can use
the VendContainer method of accessing application documents.

Always use the VendDocuments method instead.

Note that we'll also re-root the Documents folder as the root of the app
container is inaccessible ("EPERM") to avoid users fiddling with it.

See https://github.com/libimobiledevice/libimobiledevice/issues/193#issuecomment-95280639

Created attachment 323856 [details] [review]
afc: Don't list inaccessible applications

As we can only start HouseArrest for applications that have
UIFileSharingEnabled turned on, there's absolutely no need to list the
other applications.

See https://github.com/libimobiledevice/libimobiledevice/issues/193

Review of attachment 323856 [details] [review]:

It seems to me that you can remove hidden flag from AppInfo struct at all and also remove the relevant code in g_vfs_backend_afc_set_info_from_app...

Review of attachment 323855 [details] [review]:

The change looks good, however I can't test it and truly I have no idea what is it exactly doing and why we need this... so feel free to push it as you are here the most knowledgeable person about AFC...

Created attachment 324250 [details] [review]
afc: Fix accessing applications with HouseArrest

Only sideloaded applications (development versions for example) can use
the VendContainer method of accessing application documents.

Always use the VendDocuments method instead.

Note that we'll also re-root the Documents folder as the root of the app
container is inaccessible ("EPERM") to avoid users fiddling with it.

See https://github.com/libimobiledevice/libimobiledevice/issues/193#issuecomment-95280639

Created attachment 324251 [details] [review]
afc: Don't list inaccessible applications

As we can only start HouseArrest for applications that have
UIFileSharingEnabled turned on, there's absolutely no need to list the
other applications.

See https://github.com/libimobiledevice/libimobiledevice/issues/193

(In reply to Ondrej Holy from comment #3)
> Review of attachment 323856 [details] [review] [review]:
> 
> It seems to me that you can remove hidden flag from AppInfo struct at all
> and also remove the relevant code in g_vfs_backend_afc_set_info_from_app...

Done. I've also removed a lot of special-casing we used to have in the other patch for when we had access to the application's container. Now that it's not the case, we can't have any hidden files besides the "normal" ones.

Thanks! The patches look sane to me. I have no chance to test them as I told before, so feel free to push them on your own...

Attachment 324250 [details] pushed as b8ad223 - afc: Fix accessing applications with HouseArrest
Attachment 324251 [details] pushed as 069cbac - afc: Don't list inaccessible applications