After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763544 - Test not compatible with Python 3
Test not compatible with Python 3
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-12 19:02 UTC by Jan Tojnar
Modified: 2016-03-13 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch replacing itervalues for values (681 bytes, patch)
2016-03-12 19:02 UTC, Jan Tojnar 		none Details | Review
Patch replacing itervalues for values (989 bytes, patch)
2016-03-13 12:19 UTC, Jan Tojnar 		none Details | Review

Description Jan Tojnar 2016-03-12 19:02:03 UTC 
Created attachment 323772 [details] [review]
Patch replacing itervalues for values

In the file test-networkmanager-service.py, on line 1085 there is a call to itervalues method, which is no longer available in Python 3. This causes the tests (and thus the build) to fail on Arch Linux which uses Python 3 as default.

It should be replaced with a call to values method which is supported by both Python 2 and Python 3:

* https://docs.python.org/2.7/library/stdtypes.html#dict.values
* https://docs.python.org/3.5/library/stdtypes.html#dict.values
Comment 1 Thomas Haller 2016-03-13 11:44:57 UTC 
Hi,

Please state the name you wish as author for the patch, in usual git format (like "Firstname Surname <user@email.tld>").

Or even better, please create the patch with `git format-patch`, which already entails this information.
Comment 2 Jan Tojnar 2016-03-13 12:19:47 UTC 
Created attachment 323791 [details] [review]
Patch replacing itervalues for values