GNOME Bugzilla – Bug 763518
Add sidebar toggler to the menu
Last modified: 2016-10-03 15:52:41 UTC
As the hide/show sidebar shortcut already exists, it makes sense to have this option to select in the menu in order to toggle the sidebar visibility easily.
Created attachment 323738 [details] [review] Add sidebar toggler to the menu As the hide/show sidebar shortcut already exists, it makes sense to have this option to select in the menu in order to toggle the sidebar visibility easily.
Thanks; we are currently frozen for the 3.20 release but this can certainly get in afterwards. However this made me realize the ctrl-F9 that is displayed in the shortcut help window is not correct, it should be F9.
(In reply to Frederic Peters from comment #2) > Thanks; we are currently frozen for the 3.20 release but this can certainly > get in afterwards. However this made me realize the ctrl-F9 that is > displayed in the shortcut help window is not correct, it should be F9. Yes, I realized the incorrect shortcut too, but I forgot to file a bug :/ . I was not sure if the shortcut displayed in the help window was wrong or not. Thanks!
No worries, I pushed a fix for the shortcut window already.
*** Bug 764561 has been marked as a duplicate of this bug. ***
Created attachment 325282 [details] [review] Add sidebar toggler to the menu As the hide/show sidebar shortcut already exists, it makes sense to have this option to select in the menu in order to toggle the sidebar visibility easily. Includes fixed accelerator (F9). https://bugzilla.gnome.org/show_bug.cgi?id=323738
Still not ready for merging?
Review of attachment 325282 [details] [review]: The "Show sidebar" text would be shown in the menu item even if the sidebar is currently being shown, and that doesn't make much sense. Other applications, like GEdit, have a menu item with a checkbox where the item just says "Side panel", and that's much more clear I think. Could you try to set that up instead? Another option would be to name the menu item "Toggle side panel visibility", but I think the checkbox would still be better and more consistent with other applications.
Created attachment 327471 [details] [review] Text label changed to be more clear
Created attachment 327472 [details] [review] Text label changed to be more clear. patch, sorry.
Ping.
Review of attachment 327472 [details] [review]: This patch looks good to me.
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
This patch broke the string freeze. Please revert it or branch devhelp for gnome-3-22 before it.
The gnome-3-22 branch now exists, closing the bug.
(In reply to Sébastien Wilmet from comment #15) > The gnome-3-22 branch now exists, closing the bug. I assumed the stable branch was always created on a .0 release; sorry for the confusion.