After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763505 - EogPrintPreview: Silence -Wsign-compare and -Wswitch-default
EogPrintPreview: Silence -Wsign-compare and -Wswitch-default
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
3.19.x
Other All
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-11 18:05 UTC by Debarshi Ray
Modified: 2016-03-14 19:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
EogPrintPreview: Silence -Wsign-compare (988 bytes, patch)
2016-03-11 18:06 UTC, Debarshi Ray 		none Details | Review
EogPrintPreview: Silence -Wswitch-default (1.12 KB, patch)
2016-03-11 18:07 UTC, Debarshi Ray 		none Details | Review

Description Debarshi Ray 2016-03-11 18:05:48 UTC 
Some time ago when I added AX_COMPILER_FLAGS to gnome-photos, I had to silence -Wsign-compare and -Wswitch-default in our copy of EogPrintPreview.

Here is a fly-by patch to "upstream" the changes.
Comment 1 Debarshi Ray 2016-03-11 18:06:50 UTC 
Created attachment 323727 [details] [review]
EogPrintPreview: Silence -Wsign-compare
Comment 2 Debarshi Ray 2016-03-11 18:07:13 UTC 
Created attachment 323728 [details] [review]
EogPrintPreview: Silence -Wswitch-default
Comment 3 Felix Riemann 2016-03-14 19:01:45 UTC 
Thanks!
Pushed the sign-compare fix with additional constness. :)

commit 4e74b7661893e64547858db6e4775e012bb63e0a
Author: Debarshi Ray <>
Date:   Fri Mar 11 19:01:22 2016 +0100

    EogPrintPreview: Silence -Wswitch-default
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763505

commit be81fa70d6f8ca82ee9beec8dbaf5391f9c5d36a
Author: Debarshi Ray <>
Date:   Fri Mar 11 18:54:49 2016 +0100

    EogPrintPreview: Silence -Wsign-compare
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763505
---
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.