After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763502 - rtpsource: make "sdes" property writable
rtpsource: make "sdes" property writable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.8.2
Other Linux
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-11 16:09 UTC by Miguel París Díaz
Modified: 2018-10-28 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpsource: do "sdes" property writable (2.89 KB, patch)
2016-03-11 16:09 UTC, Miguel París Díaz 		rejected Details | Review
rtpsession: Allow changing the SDES at runtime (5.14 KB, patch)
2018-10-16 21:48 UTC, Olivier Crête 		committed Details | Review

Description Miguel París Díaz 2016-03-11 16:09:00 UTC 
Created attachment 323721 [details] [review]
rtpsource: do "sdes" property writable

This is needed to change the SDES of the RtpSources
Comment 1 Miguel París Díaz 2016-05-10 08:18:58 UTC 
Hello,
could we merge this patch or there is some problem?

Thanks!!
Comment 2 Olivier Crête 2018-10-16 21:47:52 UTC 
Review of attachment 323721 [details] [review]:

Doing this as the rtpsource level is unsafe if it can change at runtime, it needs to be protected by the rtpsession lock. See the attached patch that allows changing it at the session level instead.
Comment 3 Olivier Crête 2018-10-16 21:48:17 UTC 
Created attachment 373945 [details] [review]
rtpsession: Allow changing the SDES at runtime

Make it possible to modify the SDES in a packet at runtime.
Comment 4 Olivier Crête 2018-10-28 12:11:51 UTC 
Attachment 373945 [details] pushed as cc69c87 - rtpsession: Allow changing the SDES at runtime