GNOME Bugzilla – Bug 763494
h265parse: Segfault while tranforming hevc packetized stream to nal aligned bytestream
Last modified: 2016-04-14 17:43:33 UTC
Created attachment 323703 [details] sample mkv stream The following pipeline will segfault: DISPLAY=:0 gst-launch-1.0 -v filesrc location= sample.mkv ! matroskademux ! h265parse ! "video/x-h265, stream-format=byte-stream, alignment=nal" ! vaapidecode ! vaapisink Sample stream attached.
Created attachment 323705 [details] [review] videoparsers: h265: Fix segfault whiile trasforming to nal aligned bytestream
It is high time for us to make a base_h264_h265_class !
Comment on attachment 323705 [details] [review] videoparsers: h265: Fix segfault whiile trasforming to nal aligned bytestream This code looks familiar ;) Thanks!
Sreerenj, Thanks for the patch. To whoever merges this, I wouldn't nitpick if it wasn't in the subject line of the commit. Can you change the "whiile" into "while"?
gsth264parse and gsth265parse look to be in sync. Except for implementation design details that I can sync *after* the freeze. For example gsth264parse moving a block of instructions to a function _reset_stream_info(), or gsth264parse using GST_H265_PARSER_OK and gsth265parse using GST_H265_PARSER_ERROR. function digit_to_string() and others defined at a different place of the file. Making the implementation design of both match will make future syncing through diff a lot easier/faster. I will do this after the freeze.
(In reply to Luis de Bethencourt from comment #4) > Sreerenj, > Thanks for the patch. > > To whoever merges this, > I wouldn't nitpick if it wasn't in the subject line of the commit. Can you > change the "whiile" into "while"? Aha sorry, going to push it... :)
commit 92f4eb45abbe5ada79d8752b58949f2a73af6d90 Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Date: Fri Mar 11 17:34:03 2016 +0200 videoparsers: h265: Fix segfault while transforming hevc to nal aligned bytestream Create temporary ParseFrame and copy the nal size buffer region for each nal unit like we did for h264. https://bugzilla.gnome.org/show_bug.cgi?id=763494
Review of attachment 323705 [details] [review]: Pushed.
Thanks Sreerenj! Great work :)