After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763467 - "Add Profile" dialog title not localized
"Add Profile" dialog title not localized
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Color
git master
Other Linux
: Normal minor
: ---
Assigned To: Richard Hughes
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-10 17:14 UTC by Felix Zhang
Modified: 2016-10-03 12:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch to fix the problem. (892 bytes, patch)
2016-03-10 17:14 UTC, Felix Zhang 		none Details | Review

Description Felix Zhang 2016-03-10 17:14:49 UTC 
Created attachment 323654 [details] [review]
A patch to fix the problem.

In g-c-c "Color" panel, select a display, click the "Add profile" button. The Popup "Add Profile" dialog title is not localized.
This is because this string in panels/color/color.ui is not marked as translatable and lacks translations in po files.

A patch is attached, marking the " Add Profile"string as translatable and changed it to "Add profile" so that it reuses the existing translations of the "Add profile" button.
Comment 1 Richard Hughes 2016-03-15 12:47:15 UTC 
I can push this for 3-20, but for master we'll want a Title Caps version as it's a window title.
Comment 2 Pierre Amadio 2016-10-03 12:49:14 UTC 
I could not reproduce the problem on a fresh jhbuild.
Looking at ./gnome-control-center/panels/color/color.ui it looks like 'Add Profile' in dialog_assign is already translatable.

The patch has been commited in 74ff9c98d0bf87e2c8ebb987485a57079378f8fc
Comment 3 Bastien Nocera 2016-10-03 12:54:13 UTC 
commit c7a5451474fbb8dc21860add76c8c1aed4e249bc
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Oct 3 14:53:09 2016 +0200

    color: Use title caps for "Add profile" dialogue title
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763467