Created attachment 323603 [details] [review]
file-undo-operations: replace GSimpleAsyncResult API with GTask

In Nautilus, undo operations are performed as asynchronous tasks, using the
GSimpleAsyncRequest API. Because this API is now deprecated, replace it with the
GTask API.

Review of attachment 323603 [details] [review]:

Took me some time to remember the details of the undo implementation... it's a little messy (but correct and flexible).

LGTM thanks!

(to 3.20 as well)

::: libnautilus-private/nautilus-file-undo-operations.c
@@ +246,2 @@
 {
+        FileUndoInfoOpRes *op_res = g_task_propagate_pointer (G_TASK (res), error);

put functions calls to be after the declaration of variables?
Castings and constant initialization are ok, but not functions calls and it's a warning in C90 since it forbids mixed declarations and code.

Review of attachment 323603 [details] [review]:

I mean it's good except for the nitpick I pointed out.

Created attachment 323651 [details] [review]
file-undo-operations: replace GSimpleAsyncResult API with GTask

In Nautilus, undo operations are performed as asynchronous tasks, using the
GSimpleAsyncRequest API. Because this API is now deprecated, replace it with the
GTask API.

Review of attachment 323651 [details] [review]:

LGTM now, can you push it to master and 3-20?

Created attachment 323696 [details] [review]
file-undo-operations: replace GSimpleAsyncResult API with GTask

In Nautilus, undo operations are performed as asynchronous tasks, using the
GSimpleAsyncRequest API. Because this API is now deprecated, replace it with the
GTask API.

(In reply to Razvan Chitu from comment #6)
> Created attachment 323696 [details] [review] [review]
> file-undo-operations: replace GSimpleAsyncResult API with GTask
> 
> In Nautilus, undo operations are performed as asynchronous tasks, using the
> GSimpleAsyncRequest API. Because this API is now deprecated, replace it with
> the
> GTask API.

^ updated so it can be applied over 731a7ed

Review of attachment 323696 [details] [review]:

Looks good thanks!

Attachment 323696 [details] pushed as 874abe1 - file-undo-operations: replace GSimpleAsyncResult API with GTask

Attachment 323696 [details] pushed as 23e418b - file-undo-operations: replace GSimpleAsyncResult API with GTask