After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763385 - Doesn't support close command
Doesn't support close command
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-09 17:27 UTC by Máirín Duffy
Modified: 2016-04-29 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ircParser: Add /close command (1.30 KB, patch)
2016-03-09 17:59 UTC, Florian Müllner 		committed Details | Review
chatroomManager: Fix getRoomByName() for rooms without channel (1.05 KB, patch)
2016-03-09 18:46 UTC, Florian Müllner 		committed Details | Review

Description Máirín Duffy 2016-03-09 17:27:46 UTC 
Hi, I'm used to using the /close command in xchat and hexchat to part from a channel. Polari only seems to support /part. I'm trying to get used to this, but it would be nice to support /close as well since a lot of clients allow this.
Comment 1 Florian Müllner 2016-03-09 17:59:24 UTC 
Created attachment 323531 [details] [review]
ircParser: Add /close command

It's simply a synonym of /part, so no reason to not add it for users
used to it.

Untested, but should work. Unfortunately it adds a translatable string (for the help message), so we either need a freeze break request or wait until we branch for 3.22 ...
Comment 2 Florian Müllner 2016-03-09 18:46:30 UTC 
Created attachment 323536 [details] [review]
chatroomManager: Fix getRoomByName() for rooms without channel

This somehow slipped through the cracks when we started to show
offline rooms - just use the :channel-name property instead of
TpChannel:identifier, as its available independently from the
connection status.

Drive-by fix found while testing.
Comment 3 Florian Müllner 2016-03-09 18:47:18 UTC 
Comment on attachment 323536 [details] [review]
chatroomManager: Fix getRoomByName() for rooms without channel

Attachment 323536 [details] pushed as 426f35f - chatroomManager: Fix getRoomByName() for rooms without channel
Comment 4 Florian Müllner 2016-04-29 17:12:08 UTC 
Attachment 323531 [details] pushed as 795dc68 - ircParser: Add /close command