After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763328 - Add 'aeroway' place type
Add 'aeroway' place type
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-08 15:39 UTC by Zeeshan Ali
Modified: 2016-03-09 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
scripts/extractPoiTypesFromID: Human-friendly JSON (540.40 KB, patch)
2016-03-08 15:39 UTC, Zeeshan Ali
committed Details | Review
extractPoiTypesFromID: Add 'aeroway' type (12.86 KB, patch)
2016-03-08 15:39 UTC, Zeeshan Ali
committed Details | Review

Description Zeeshan Ali 2016-03-08 15:39:04 UTC
So that I can add my helipads. :-P
Comment 1 Zeeshan Ali 2016-03-08 15:39:24 UTC
Created attachment 323410 [details] [review]
scripts/extractPoiTypesFromID: Human-friendly JSON

Human-friendly JSON.
Comment 2 Zeeshan Ali 2016-03-08 15:39:30 UTC
Created attachment 323411 [details] [review]
extractPoiTypesFromID: Add 'aeroway' type
Comment 3 Jonas Danielsson 2016-03-09 06:26:45 UTC
Review of attachment 323410 [details] [review]:

Looks fine, thanks!
Comment 4 Jonas Danielsson 2016-03-09 06:27:14 UTC
Review of attachment 323411 [details] [review]:

Looks good, thanks!
Comment 5 Marcus Lundblad 2016-03-09 07:21:01 UTC
Review of attachment 323411 [details] [review]:

You also need to include the "aeroway" key in osmTypes.js
Comment 6 Zeeshan Ali 2016-03-09 13:12:34 UTC
Attachment 323410 [details] pushed as fe264c3 - scripts/extractPoiTypesFromID: Human-friendly JSON
Attachment 323411 [details] pushed as 861b9fa - extractPoiTypesFromID: Add 'aeroway' type