After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763311 - mpeg2: treat profile 422 as main profile
mpeg2: treat profile 422 as main profile
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-08 11:54 UTC by Víctor Manuel Jáquez Leal
Modified: 2018-05-04 12:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mpeg2: treat profile 422 as main profile (2.88 KB, patch)
2016-03-08 11:54 UTC, Víctor Manuel Jáquez Leal
rejected Details | Review

Description Víctor Manuel Jáquez Leal 2016-03-08 11:54:31 UTC
This is an RFC. It works in Intel backend in Haswell. I don't know if other 
chips or other backends can support it.
Comment 1 Víctor Manuel Jáquez Leal 2016-03-08 11:54:34 UTC
Created attachment 323385 [details] [review]
mpeg2: treat profile 422 as main profile

Intel driver can handle MPEG2 422 profile as main profile, either with 4:2:2
chroma or 4:2:0
Comment 2 sreerenj 2016-03-09 14:39:54 UTC
In theory , it is not right to map MPGE 422 to Simple or Main always. At lease i can see features  supported in 422 which are not in simple/main. For eg: chroma_intra_quantiser/chroma_non_intra_quantiser matrices are need not be supported by the decoder for Simple/Main. Also coded_block_pattern_1 (4:2:2) also need not be supported by Simple/Main. 

Of course, there is no attribute setting for chroma format  in libva api or in intel-driver(as per what i can see from source) for mpeg2 decode.


IMHO,
-- As per spec we can't map 422 profile to Main always
-- If we only considering intel-vaapi-driver, we can consider this patch. But someone have to test it in the older SandyBridge platform and the stream should have chroma_intra_quantiser/chroma_non_intra_quantiser matrices.

Also would be good if you can ask about this in libva mailing list.
Comment 3 Víctor Manuel Jáquez Leal 2018-05-04 12:01:35 UTC
let's close this issue. If it comes up later, we could reconsider this patch.