After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763310 - ahcsrc: replace with new imageformat
ahcsrc: replace with new imageformat
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-08 11:54 UTC by Justin Kim
Modified: 2016-03-08 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
imageformat (27.56 KB, patch)
2016-03-08 11:54 UTC, Justin Kim 		needs-work Details | Review

Description Justin Kim 2016-03-08 11:54:29 UTC 
android.graphics.ImageFormat class just provides only static fields and function.
But I think it is easier if it is handled as GObject/GstObject like other classes.
Comment 1 Justin Kim 2016-03-08 11:54:52 UTC 
Created attachment 323386 [details] [review]
imageformat
Comment 2 Sebastian Dröge (slomo) 2016-03-08 12:07:09 UTC 
Comment on attachment 323386 [details] [review]
imageformat

Please don't make this a GObject, that's just a useless amount of extra code.
Comment 3 Justin Kim 2016-03-08 12:51:44 UTC 
> Please don't make this a GObject, that's just a useless amount of extra code.

Actually, I started this to get rid of global variables such as ImageFormat_xxx and init/deninit functions from gstamc.c. Do you think it is good as it is? If yes, I'll abandon it.
Comment 4 Sebastian Dröge (slomo) 2016-03-08 13:00:35 UTC 
Yes, global variables are not really a problem for "constants" here.