After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763285 - gdkwindow/Win32: Make update_style_bits() available across the GDK-Win32 backend
gdkwindow/Win32: Make update_style_bits() available across the GDK-Win32 backend
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-03-08 04:54 UTC by Fan, Chun-wei
Modified: 2016-03-08 05:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make update_style_bits() available within the GDK-Win32 backend (5.47 KB, patch)
2016-03-08 05:06 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2016-03-08 04:54:15 UTC 
Hi,

This is a continuation of bug 763080, so that we can update the style bits for a window when needed, by directly calling update_style_bits(), within the GDK-Win32 backend, instead of doing so by doing gdk_window_set_type_hint().

With blessings, thank you!
Comment 1 Fan, Chun-wei 2016-03-08 05:06:42 UTC 
Created attachment 323351 [details] [review]
Make update_style_bits() available within the GDK-Win32 backend

Hi,

We achieve this by simply renaming it, making the function non-static, and instead declare its prototype in the gdkwindow-win32.h private header.

With blessings, thank you!
Comment 2 LRN 2016-03-08 05:20:13 UTC 
Review of attachment 323351 [details] [review]:

I kind of expected smaller patch (add a new function that calls update_style_bits(), not rename update_style_bits() itself and all of its invocations), but this will work just as well. Push.
Comment 3 Fan, Chun-wei 2016-03-08 05:30:14 UTC 
Hi LRN,

Thanks, I have pushed the patch as 15c9b3e.

With blessings, thank you!