After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763264 - Play controls: previous, play and next buttons aren't linked
Play controls: previous, play and next buttons aren't linked
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-07 19:44 UTC by Allan Day
Modified: 2016-03-17 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (1.65 MB, image/png)
2016-03-07 19:44 UTC, Allan Day
  Details
backend: Re-link the controls after theme changes (838 bytes, patch)
2016-03-16 15:15 UTC, Bastien Nocera
committed Details | Review
after/before linked/unlinked screenshot (8.00 KB, image/png)
2016-03-16 15:28 UTC, Bastien Nocera
  Details

Description Allan Day 2016-03-07 19:44:14 UTC
Created attachment 323321 [details]
screenshot

In the play controls bar, the previous, play and next buttons aren't linked. This looks visually awkward because they are touching.

See the attached screenshot.
Comment 1 Bastien Nocera 2016-03-08 12:51:27 UTC
Regression in the theme? Works in 3.18.

Lapo?
Comment 2 Lapo Calamandrei 2016-03-11 21:47:15 UTC
All the widgets in osd were considered "linked" in the past (since osd originated fron in-line toolbars, long story), at the beginning of this cycle we stopped doing that, so now you need to set the linked styleclass on the container box as for other buttons.
I'm pretty sure it's was you requesting it also :)
Comment 3 Bastien Nocera 2016-03-15 15:29:18 UTC
(In reply to Lapo Calamandrei from comment #2)
> All the widgets in osd were considered "linked" in the past (since osd
> originated fron in-line toolbars, long story), at the beginning of this
> cycle we stopped doing that, so now you need to set the linked styleclass on
> the container box as for other buttons.

on box containing the buttons, or on the buttons themselves. I can't parse the sentence.

> I'm pretty sure it's was you requesting it also :)

Requesting what?
Comment 4 Lapo Calamandrei 2016-03-15 17:21:33 UTC
You need the class on the box containing the buttons.
I thought it was you requesting to not always consider the osd widgetry linked by default, for some reasons I can't remember.
Comment 5 Bastien Nocera 2016-03-16 15:15:40 UTC
Created attachment 324111 [details] [review]
backend: Re-link the controls after theme changes
Comment 6 Bastien Nocera 2016-03-16 15:28:55 UTC
Created attachment 324114 [details]
after/before linked/unlinked screenshot
Comment 7 Philip Withnall 2016-03-16 19:05:04 UTC
Review of attachment 324111 [details] [review]:

Looks good to me.
Comment 8 Bastien Nocera 2016-03-17 10:39:53 UTC
Attachment 324111 [details] pushed as ee33197 - backend: Re-link the controls after theme changes