GNOME Bugzilla – Bug 763259
Location access: various UI improvements
Last modified: 2016-03-16 12:44:54 UTC
This is a collection of UI issues with the new location access dialog in the privacy panel. 1. Spacing is off inside the dialog. I'd suggest adding 12px margin-bottom to location-vbox and 12px margin to location_dialog 2. "Location Services" label isn't vertically centered inside the list row. 3. The idea in the mockups was to have the application switches lose their colour when location services is off, rather than making the insensitive. This would allow a user to change individual application settings while location services are off globally. 4. When the location switch is off, there's no need to dim the entire applications section. It would be better just to change the colour of the switches, as described above. 5. The long description string could be improved. Issues with it: * "WiFi" should be "Wi-Fi" * We generally say "mobile broadband" rather than "GPS" in settings. * Could be confusing if the device doesn't have Wi-Fi or GPS. * "enabling" is a sucky word. The second sentence also implies that they are turned off. * "determine" isn't everyday language. A better label might be something like: "Location services allow applications to know your location. Having Wi-Fi and mobile broadband switched on increases accuracy." This assumes that the device has Wi-Fi and mobile broadband with GPS - can we detect that and change the string accordingly?
Well I already filed bug#763107 for this but since you provided more details here, I'll mark that as dup.
*** Bug 763107 has been marked as a duplicate of this bug. ***
(In reply to Allan Day from comment #0) > > A better label might be something like: "Location services allow > applications to know your location. Having Wi-Fi and mobile broadband > switched on increases accuracy." This assumes that the device has Wi-Fi and > mobile broadband with GPS - can we detect that and change the string > accordingly? Yes but unless some code in control-centre is already doing that, it won't be a simple fix and I won't be able to fix that in 3.20.
*** Bug 763261 has been marked as a duplicate of this bug. ***
Also there is redundant padding at the right side of application access switches as reported by Cosimo in bug#763261.
(In reply to Allan Day from comment #0) > > 2. "Location Services" label isn't vertically centered inside the list row. Are you sure about this? I see it completely centered (vertically) here and also i don't see any reason why it won't be (looking at the .ui definition).
Created attachment 323547 [details] [review] privacy: Fix margins around location dialog widgets
Created attachment 323548 [details] [review] privacy: Better description for 'Location Services' New string from Allan Day.
(In reply to Allan Day from comment #0) > > 3. The idea in the mockups was to have the application switches lose their > colour when location services is off, rather than making the insensitive. > This would allow a user to change individual application settings while > location services are off globally. > > 4. When the location switch is off, there's no need to dim the entire > applications section. It would be better just to change the colour of the > switches, as described above. I'm not so sure it makes sense to let user chance some settings when they have no effect. Still if you think it's a good idea, I'd go with it but until it's actually possible to change the colors (bug#725648 ?), I'd want to keep the current behaviour.
Created attachment 323595 [details] close up screenshot (In reply to Zeeshan Ali (Khattak) from comment #6) > (In reply to Allan Day from comment #0) > > > > 2. "Location Services" label isn't vertically centered inside the list row. > > Are you sure about this? ... Yes. It is clearly not centered - see the screenshot.
(In reply to Zeeshan Ali (Khattak) from comment #3) > (In reply to Allan Day from comment #0) > > > > A better label might be something like: "Location services allow > > applications to know your location. Having Wi-Fi and mobile broadband > > switched on increases accuracy." This assumes that the device has Wi-Fi and > > mobile broadband with GPS - can we detect that and change the string > > accordingly? > > Yes but unless some code in control-centre is already doing that, it won't > be a simple fix and I won't be able to fix that in 3.20. In that case, it might have to be something like this: "Location services allow applications to know your location. Using Wi-Fi and mobile broadband increases accuracy." It would be better not to mention Wi-Fi and mobile broadband if it isn't available, of course.
Review of attachment 323547 [details] [review]: Sure.
Review of attachment 323548 [details] [review]: Fine, will need to ask for freeze break though.
(In reply to Zeeshan Ali (Khattak) from comment #9) > (In reply to Allan Day from comment #0) > > > > 3. The idea in the mockups was to have the application switches lose their > > colour when location services is off, rather than making the insensitive. > > This would allow a user to change individual application settings while > > location services are off globally. > > > > 4. When the location switch is off, there's no need to dim the entire > > applications section. It would be better just to change the colour of the > > switches, as described above. > > I'm not so sure it makes sense to let user chance some settings when they > have no effect. It's true that the practical benefit is somewhat marginal. There is a logical argument for the change though: I've filed bug 763443 for this. > Still if you think it's a good idea, I'd go with it but > until it's actually possible to change the colors (bug#725648 ?), I'd want > to keep the current behaviour. There's still no need to dim the entire applications section - it doesn't communicate anything new, and makes the UI harder to read. Just make the switches insensitive when location services are off.
Created attachment 323635 [details] [review] privacy: Better description for 'Location Services' New string from Allan Day.
Created attachment 323636 [details] [review] privacy: Vertically center "Location Services" label
Created attachment 323637 [details] [review] privacy: Only disable apps switches Let's not disable the whole Applications section when "Location Services" are disabled but rather only the individual app permission switches.
Review of attachment 323548 [details] [review]: Adding patch status
Review of attachment 323636 [details] [review]: Yep
Review of attachment 323637 [details] [review]: Looks good.
Review of attachment 323635 [details] [review]: Patch status again.
Attachment 323547 [details] pushed as 76e3a53 - privacy: Fix margins around location dialog widgets Attachment 323635 [details] pushed as a2ab6d4 - privacy: Better description for 'Location Services' Attachment 323636 [details] pushed as d0c1ed6 - privacy: Vertically center "Location Services" label Attachment 323637 [details] pushed as 48c66a5 - privacy: Only disable apps switches
(In reply to Zeeshan Ali (Khattak) from comment #16) > Created attachment 323636 [details] [review] [review] > privacy: Vertically center "Location Services" label The label isn't centered in the screenshot that's in the release notes. Are you sure this issue got fixed?
(In reply to Allan Day from comment #23) > (In reply to Zeeshan Ali (Khattak) from comment #16) > > Created attachment 323636 [details] [review] [review] [review] > > privacy: Vertically center "Location Services" label > > The label isn't centered in the screenshot that's in the release notes. Are > you sure this issue got fixed? Not sure where release notes screenshots come from and if it's up2date but I showed the UI before and after the change to Richard Hughes and he verified that it did it's job. TBH, I can't tell on my own. :(