After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763220 - mpegvideoparse: Support non-hierarchical profile/level again [REGRESSION]
mpegvideoparse: Support non-hierarchical profile/level again [REGRESSION]
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal blocker
: 1.7.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-07 12:06 UTC by Edward Hervey
Modified: 2016-03-11 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpegvideoparse: Add support for 4:2:2 profile (1.55 KB, patch)
2016-03-07 12:07 UTC, Edward Hervey 		reviewed Details | Review
mpegvideoparser: Handle non-hierarchical profiles again (4.12 KB, patch)
2016-03-09 14:14 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2016-03-07 12:06:56 UTC 
See commit
Comment 1 Edward Hervey 2016-03-07 12:07:00 UTC 
Created attachment 323259 [details] [review]
mpegvideoparse: Add support for 4:2:2 profile

The only level I can see being supported is the main one.
Comment 2 Sebastian Dröge (slomo) 2016-03-07 12:22:40 UTC 
Comment on attachment 323259 [details] [review]
mpegvideoparse: Add support for 4:2:2 profile

Should double-check with the spec but seems ok to me otherwise
Comment 3 Edward Hervey 2016-03-09 14:14:36 UTC 
Created attachment 323513 [details] [review]
mpegvideoparser: Handle non-hierarchical profiles again

This is a regression from since mpegvideoparser was switched to
use the codecparsing library.

The problem is that the high bit of the profile_and_level is used
to specify non-hierarchical profiles and levels. Unfortunately we
were discarding that information.

Expose that escape bit, and use it in the element
Comment 4 Edward Hervey 2016-03-09 14:21:20 UTC 
commit 5ebf1d477de44a45ce3a8e320a86cc3bf83c2a8e
Author: Edward Hervey <edward@centricular.com>
Date:   Mon Mar 7 13:04:08 2016 +0100

    mpegvideoparser: Handle non-hierarchical profiles again
    
    This is a regression from since mpegvideoparser was switched to
    use the codecparsing library.
    
    The problem is that the high bit of the profile_and_level is used
    to specify non-hierarchical profiles and levels. Unfortunately we
    were discarding that information.
    
    Expose that escape bit, and use it in the element
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763220