After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763216 - GtkTextView's top-margin/bottom-margin don't work with non-scrolling textview
GtkTextView's top-margin/bottom-margin don't work with non-scrolling textview
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTextView
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-03-07 10:54 UTC by Timm Bäder
Modified: 2016-03-09 16:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Testcase (535 bytes, text/x-c)
2016-03-07 10:54 UTC, Timm Bäder 		  Details
Make sure the allocation is at least as big as the borders (900 bytes, patch)
2016-03-09 10:31 UTC, Timm Bäder 		accepted-commit_now Details | Review

Description Timm Bäder 2016-03-07 10:54:56 UTC 
Created attachment 323249 [details]
Testcase

As soon as the textview needs to grow vertically, the top-margin is ignored when only that is set, or the text is cut off at the top if both top-margin and bottom-margin is set. See attached video.
Comment 1 Timm Bäder 2016-03-07 10:56:31 UTC 
Video showing the issue: http://videobin.org/+bwr/fgr.ogg
Comment 2 Timm Bäder 2016-03-09 10:31:21 UTC 
Created attachment 323495 [details] [review]
Make sure the allocation is at least as big as the borders

seems overly simplistic, but works for my use case, no unittests fail and gedit seems to look normal as well.
Comment 3 sébastien lafargue 2016-03-09 15:17:04 UTC 
seems logical and all tests i can think of are ok, so LGTM
Comment 4 Matthias Clasen 2016-03-09 15:41:00 UTC 
Review of attachment 323495 [details] [review]:

ok then
Comment 5 Timm Bäder 2016-03-09 16:26:16 UTC 
Pushed, thanks.