Created attachment 323242 [details] [review]
build: Fix gettext domain after recent changes

Commit 1b11db36463116310ec2e40a7072d205a6536532 that switched the build
system to use upstream gettext intead glib-gettext accidentally changed
the gettext domain from atk10 to atk; this commit changes it back.

Review of attachment 323242 [details] [review]:

::: po/Makevars
@@ +3,2 @@
 # Usually the message domain is the same as the package name.
+DOMAIN = atk10

I think that instead of hardcoding the value, it would be better to replace PACKAGE for GETTEXT_PACKAGE (that is defined at configure.ac). Doing that, we can also remove that "# Usually the message ..." comment.

Sure, I think it's a good idea, but I don't know how to get the GETTEXT_PACKAGE substitution to work. Just sticking 'DOMAIN = $(GETTEXT_PACKAGE)' in there doesn't seem to work for me.

Do you know how to do this?

(In reply to Kalev Lember from comment #3)
> Sure, I think it's a good idea, but I don't know how to get the
> GETTEXT_PACKAGE substitution to work. Just sticking 'DOMAIN =
> $(GETTEXT_PACKAGE)' in there doesn't seem to work for me.
> 
> Do you know how to do this?

The way to do that would be create a Makevars.in, so on configure time GETTEXT_PACKAGE is passed and a Makevars file is created. Having said so, I have just checked other projects, like clutter, and they don't go so into the details. They just duplicate the name on both Makevars and configure.ac. So probably it is better to just go simple.

Review of attachment 323242 [details] [review]:

As I mentioned on previous comment, in the end I think that it would be better to just go simple, and go with your patch.

Sorry for the back and forth, and thank you for the patch.

No problem, thanks for the review!

Attachment 323242 [details] pushed as c82f438 - build: Fix gettext domain after recent changes