GNOME Bugzilla – Bug 763174
The geometry must never be set to 0 once the node is added to the SG
Last modified: 2016-04-23 08:02:19 UTC
Created attachment 323197 [details] [review] Proposed patch The geometry must never be set to 0 once the node is added to the SG. The application can crash otherwise.
Qt Docs suggest geometry is NULL by default. http://doc.qt.io/qt-5/qsgbasicgeometrynode.html#geometry Instead of introducing a new variable what about removing the explicit call setGeometry(0) and just testing for 0 Also I wonder if changeFormat should be calling markDirty? http://doc.qt.io/qt-5/qsggeometrynode.html#setMaterial Diane
Yes, the geometry is NULL by default, but the node is not added to the scene graph yet. But it has to be set to something different before adding it and it must never be NULL once it is added. The geometry has to be set every time we switch between a black texture (when no video is played) and between the video texture because it has different attributes. Without my patch, we set the geometry to 0, so that we can test for 0 and create a new geometry when necessary. But this crashes and so I had to introduce a new variable to catch that case.
Tested and merged. Yes it works. Probably need to learn how to make a release soon. However I was able to find some more bugs... though probably in call-ui itself.
Can this be closed then, or is there anything else outstanding to fix the bug? :) commit af4d94de093b114c5371bda522ec11075ead60ea Author: Niels Ole Salscheider <niels_ole@salscheider-online.de> Date: Sun Mar 6 13:50:03 2016 +0100 The geometry must never be set to 0 once the node is added to the SG The application can crash otherwise.
Sure.