After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763100 - ahcsrc: remove unused variable
ahcsrc: remove unused variable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-04 13:48 UTC by Justin Kim
Modified: 2016-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
remove probe properties (1.20 KB, patch)
2016-03-04 13:48 UTC, Justin Kim
none Details | Review
remove commented out block also (8.13 KB, patch)
2016-03-06 13:16 UTC, Justin Kim
committed Details | Review

Description Justin Kim 2016-03-04 13:48:34 UTC
Created attachment 323089 [details] [review]
remove probe properties

probe properties is no longer necessary.
Comment 1 Sebastian Dröge (slomo) 2016-03-05 08:08:24 UTC
Review of attachment 323089 [details] [review]:

While at it, also remove the related #if 0 code, e.g. gst_ahc_src_probe_get_properties
Comment 2 Justin Kim 2016-03-06 13:16:17 UTC
Created attachment 323193 [details] [review]
remove commented out block also
Comment 3 Nicolas Dufresne (ndufresne) 2016-03-08 16:22:18 UTC
Review of attachment 323193 [details] [review]:

Looks trivial, shall we merge ?
Comment 4 Sebastian Dröge (slomo) 2016-03-24 13:00:07 UTC
commit b9ecc42b76b7f932bc8e4b420e3f7fd98a46aabc
Author: Justin Kim <justin.kim@collabora.com>
Date:   Thu Mar 3 20:10:16 2016 +0900

    ahcsrc: remove probe_properties
    
    It's a residue of 0.10.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763100