After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763087 - double click on sha1 make selection from "All" of "Expand all" or "Collapse All"
double click on sha1 make selection from "All" of "Expand all" or "Collapse All"
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-04 10:52 UTC by Jeongsu Kim
Modified: 2016-06-05 10:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
added &nbsp; between <span> tags (704 bytes, patch)
2016-03-04 10:52 UTC, Jeongsu Kim 		none Details | Review

Description Jeongsu Kim 2016-03-04 10:52:58 UTC 
Created attachment 323077 [details] [review]
added &nbsp; between <span> tags

I usually copy sha1 of commit because it is required for the build process of my work.

I remember that gitg of version 0.x copied the sha1 whenever I select a commit but not now.
So I usually double click the sha1 to select it.

But at latest version of gitg, selection starts from "All" of "Expand All" or "Collapse All" and it makes me annoying. So now I have to manually drag from the start to end of sha1.

I took the ui code and found that "Expand All" and sha1 are at the same block in <span> tag and I think that is the problem.
I added &nbsp; between <span> tags and it works well.

Please apply attached patch or make it better.
Comment 1 jessevdk@gmail.com 2016-06-05 10:06:52 UTC 
This should no longer be valid since we switched away from webkit. In the latest gitg you can simply double click on the sha1 to select it. I've also restored setting the primary selection to the selected commit sha1.